Handle cases when a project doesn't use codeownership #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalunamel
approved these changes
Nov 26, 2024
| @@ -11,6 +11,7 @@ View code ownership for every file right in the status bar. You'll get the name | |||
| Quick access to the owning team's config file. Clicking on the status bar item will open a popup that includes a button that opens the team's config file. See [Code Teams](https://github.com/rubyatscale/code_teams) for more information on team config files. | |||
|
|
|||
| ## Installation | |||
|
|
|||
There was a problem hiding this comment.
Prettier did this on its own 🤷🏻
Comment on lines
+279
to
+295
| private async checkConfiguration(): Promise<void> { | ||
| const binaryPath = resolve(this.workspace.uri.fsPath, 'bin/codeownership'); | ||
| this.isConfigured = existsSync(binaryPath); | ||
| this.statusProvider.isConfigured = this.isConfigured; | ||
|
|
||
| if (!this.isConfigured) { | ||
| log( | ||
| 'info', | ||
| `No code ownership binary found in workspace: ${this.workspace.name}`, | ||
| ); | ||
| } else { | ||
| log( | ||
| 'info', | ||
| `Code ownership binary found in workspace: ${this.workspace.name}`, | ||
| ); | ||
| } | ||
| } |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I work on lots of codebases aside from ones with code_ownership, and I find it a little annoying to see "Owner: error!" when it isn't expected to work at all.
This adds a concept of checking that a workspace is configured for codeowners, or not. When it's not configured, it shows that with an info icon:
Unrelated, but I fixed an error I was getting while using the debugging, which fixes an infinite recursion. I assume it is either debug/dev specific, or we'd see it more.