Improving project build speed #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perryqh
force-pushed
the
ph/faster-build-project
branch
from
cf86eeb to
70c2384
Compare
perryqh
commented
Nov 10, 2024
| @@ -10,10 +10,11 @@ debug = true | |||
| clap = { version = "4.5.20", features = ["derive"] } | |||
| clap_derive = "4.5.18" | |||
| error-stack = "0.5.0" | |||
| glob-match = "0.2.1" | |||
| fast-glob = "0.4.0" | |||
There was a problem hiding this comment.
Doesn't fix any bugs, but is at least maintained
perryqh
force-pushed
the
ph/faster-build-project
branch
3 times, most recently
from
2512b4c to
18797c0
Compare
perryqh
force-pushed
the
ph/faster-build-project
branch
from
18797c0 to
7a023d9
Compare
perryqh
commented
Nov 11, 2024
| } | ||
|
|
||
| fn matches_globs(path: &Path, globs: &[String]) -> bool { | ||
| globs.iter().any(|glob| glob_match(glob, path.to_str().unwrap())) |
There was a problem hiding this comment.
This is remarkably fast. I tried caching the results of this with no performance boost
jackboberg
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
In my local testing, this is faster on a large project
bin/codeowners-rs is the current release
$ hyperfine --warmup 1 'codeowners validate' 'bin/codeowners-rs validate'
Benchmark 1: codeowners validate
Time (mean ± σ): 6.384 s ± 0.050 s [User: 6.999 s, System: 5.553 s]
Range (min … max): 6.340 s … 6.512 s 10 runs
Benchmark 2: bin/codeowners-rs validate
Time (mean ± σ): 6.820 s ± 0.783 s [User: 8.947 s, System: 33.606 s]
Range (min … max): 5.646 s … 7.494 s 10 runs
Summary
codeowners validate ran
1.07 ± 0.12 times faster than bin/codeowners-rs validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projectbuild speed by using rayon to build project entries in parallelignore::WalkBuilderiteratorProjectBuilderfor clarityNotes
The
ph/jwalkbranch contains all the approaches I tried along with a way to run benchmarks