Fix response log obfuscation #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobranco
force-pushed
the
bugfix/fix-response-log-obfuscation
branch
from
cdb1d08 to
c006435
Compare
pedrobranco
requested review from
joaopaulofonseca
and removed request for
ruimarinho
ruimarinho
reviewed
Feb 26, 2018
| @@ -49,17 +49,19 @@ function obfuscateResponse(request, instance) { | |||
| return; | |||
| } | |||
|
|
|||
| request.body = JSON.parse(request.body); | |||
There was a problem hiding this comment.
@pedrobranco shouldn't we be keeping the same string as before?
There was a problem hiding this comment.
I suggest passing the parsed body as an argument instead of mutating request.body here. I would then stringify the resulting (mutated) body object at the end of the method.
pedrobranco
force-pushed
the
bugfix/fix-response-log-obfuscation
branch
from
c006435 to
63043a1
Compare
joaopaulofonseca
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63.