Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ToggleableOutputPin to the prelude #83

Merged
merged 2 commits into from
Jul 30, 2018
Merged

add ToggleableOutputPin to the prelude #83

merged 2 commits into from
Jul 30, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented May 16, 2018

No description provided.

@japaric
Copy link
Member Author

japaric commented May 16, 2018

Should StatefulOutputPin also be in the prelude? It seems to me that is_set_{low,high} are less common than toggle, but those two methods were in the v0.1.x prelude because they were part of OutputPin and OutputPin was in the v0.1.x prelude.

therealprof
therealprof approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hannobraun
hannobraun approved these changes Jul 23, 2018
View reviewed changes
Copy link
Member

@hannobraun hannobraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, too. Unless I hear an objection, I'm going to merge this soon-ish.

@hannobraun
Copy link
Member

Should StatefulOutputPin also be in the prelude? It seems to me that is_set_{low,high} are less common than toggle, but those two methods were in the v0.1.x prelude because they were part of OutputPin and OutputPin was in the v0.1.x prelude.

I can't think of a good reason why it shouldn't be in there.

@tib8
Copy link

tib8 commented Jul 23, 2018

StatefulOutputPin is definitely needed! (For example for 1-wire protocol implementations using an open drain output pin.)

@hannobraun hannobraun mentioned this pull request Jul 30, 2018
Closed
@hannobraun hannobraun merged commit 82e2be2 into master Jul 30, 2018
peckpeck pushed a commit to peckpeck/embedded-hal that referenced this pull request Nov 10, 2022
@bors @kelnos
Merge rust-embedded#83
66e773b 
83: Update embedded-hal to 1.0.0-alpha.8 r=eldruin a=kelnos



Co-authored-by: Brian J. Tarricone <[email protected]>
peckpeck pushed a commit to peckpeck/embedded-hal that referenced this pull request Nov 10, 2022
@bors @eldruin
Merge rust-embedded#84
1ac9d6f 
84: Prepare 0.4.0-alpha.3 release r=ryankurte a=eldruin

Now that rust-embedded#83 is in, it would be good to publish a new alpha release.

Co-authored-by: Diego Barrios Romero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannobraun hannobraun hannobraun approved these changes

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@japaric @hannobraun @tib8 @therealprof