Skip to content
This repository was archived by the owner on Aug 16, 2021. It is now read-only.

warning: lint unused_doc_comment has been renamed to unused_doc_comments #245

Closed
df5602 opened this issue May 26, 2018 · 5 comments
Closed

Comments

@df5602
Copy link

df5602 commented May 26, 2018

If you use the error_chain! macro on a recent nightly, a number of warnings are generated:

warning: lint unused_doc_comment has been renamed to unused_doc_comments
 --> src/main.rs:4:1
  |
4 | / error_chain! {
5 | |     foreign_links {
6 | |         IoError(::std::io::Error);
7 | |     }
8 | | }
  | |_^
  |
  = note: #[warn(renamed_and_removed_lints)] on by default
  = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

(Playground)

I think, this is due to #50879.

I'm not sure how to correctly fix this, since just replacing #[allow(unused_doc_comment)] with #[allow(unused_doc_comments)] will not work on older compilers (including current stable).

@hoodie
Copy link

hoodie commented May 27, 2018

how about this #246

@jamesray1
Copy link

mulkieran added a commit to mulkieran/devicemapper-rs that referenced this issue May 31, 2018
So a problem that is actually in error-chain and not in our code can be
ignored. error-chain issue:
rust-lang-deprecated/error-chain#245

Signed-off-by: mulhern <[email protected]>
mulkieran added a commit to mulkieran/devicemapper-rs that referenced this issue May 31, 2018
So a problem that is actually in error-chain and not in our code can be
ignored. error-chain issue:
rust-lang-deprecated/error-chain#245

Signed-off-by: mulhern <[email protected]>
@koutheir
Copy link

koutheir commented Jun 22, 2018

@Yamakaky: This issue also happens in Rust stable starting from version 1.27.0. Please release a new version of the error_chain that removes this warning:

warning: lint unused_doc_comment has been renamed to unused_doc_comments
  --> src/errors.rs:7:1
   |
7  | / error_chain!{
8  | |     errors {
9  | |         ThreadPanic(name: &'static str, panic_parameter: ::std::boxed::Box<::std::any::Any + ::std::marker::Send>) {
10 | |             description("thread panicked"),
...  |
41 | |     }
42 | | }
   | |_^
   |
   = note: #[warn(renamed_and_removed_lints)] on by default
   = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

@Yamakaky
Copy link
Contributor

Done

@dwijnand
Copy link

@Yamakaky the 0.12.0 tag seems to be missing in https://github.com/rust-lang-nursery/error-chain/tags

mulkieran added a commit to mulkieran/devicemapper-rs that referenced this issue Jul 19, 2018
We believe that the necessity has been removed by the recent error-chain
update: rust-lang-deprecated/error-chain#245

Signed-off-by: mulhern <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants