Always call backtrace_syminfo with libbacktrace #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out if we favor backtrace_pcinfo then if there's no debuginfo in the binary (e.g. `strip -g`) then symbol information comes out! It also looks to have more accurate symbol names in terms of loading it from the symbol table rather than debuginfo where debuginfo tends to typically be a bit more terse in naming.
alexcrichton
force-pushed
the
always-syminfo
branch
from
d9c07b4 to
f6c2e00
Compare
alexcrichton
added a commit
that referenced
this pull request
May 16, 2019
This commit fixes an accidental regression with #185 where libbacktrace was updated to match the standard library by always returning the symbol table symbol. Turns out though this library was one-upping the standard library by consulting debuginfo (what it was previously doing) because debuginfo can have more accurate symbol information for inline functions, for example. The fix here is to always prefer the debuginfo function name, if present, and otherwise fall back to the symbol table symbol if necessary. Closes #186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out if we favor backtrace_pcinfo then if there's no debuginfo
in the binary (e.g.
strip -g) then symbol information comes out! Italso looks to have more accurate symbol names in terms of loading it
from the symbol table rather than debuginfo where debuginfo tends to
typically be a bit more terse in naming.