Fix test failure on Mac #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 15, 2014 15:06
… Rust commit 046062d.
Previously cargo_compile_with_invalid_code failed on Mac OS X 10.9 because $TMPDIR was a child of a symlinked directory. As a result this the error messages from rustc used the real path while the test created the expected output using the symlink. This patch normalizes the root path used by the tests to use the real path. The solution to this isn't as elegant as I'd like. Because fs::realpath isn't implemented in libstd (mozilla/rust #11857) I had to copy the implementation from librustc to avoid having to link librustc into the test binary.
ghost
mentioned this pull request
|
Closing, the tests are passing now, but thanks! |
LucioFranco
pushed a commit
to LucioFranco/cargo
that referenced
this pull request
Dec 12, 2022
Disable unnecessary features for scopeguard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously cargo_compile_with_invalid_code failed on Mac OS X 10.9 because $TMPDIR was a child of a symlinked directory. As a result this the error messages from rustc used the real path while the test created the expected output using the symlink. This patch normalizes the root path used by the tests to use the real path.
The solution to this isn't as elegant as I'd like. Because fs::realpath isn't implemented in libstd (mozilla/rust #11857) I had to copy the implementation from librustc to avoid having to link librustc into the test binary.
This depends on #14.