feat: make arg passing for fix match other subcmds #7232
Conversation
Prior to this change, `cargo fix` had no defacto method for passing additional arguments down to rustc to use when generating warnings to be fixed. We did implement a way to do so for clippy, but the hack was inconsistent with the way all other sub commands get args for rustc, where they take all args after the -- and pass them down. This change removes the clippy args method as implemented earlier and adds a new primary_unit_args passing mechanism which will work for `cargo fix` and `cargo fix --clippy`.
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| @@ -132,6 +128,7 @@ pub fn fix(ws: &Workspace<'_>, opts: &mut FixOptions<'_>) -> CargoResult<()> { | |||
|
|
|||
| let rustc = opts.compile_opts.config.load_global_rustc(Some(ws))?; | |||
| wrapper.arg(&rustc.path); | |||
| wrapper.args(&opts.primary_unit_args); | |||
There was a problem hiding this comment.
pass via wrapper's argument list. FixArgs::get() already grabs all but a few special args and forwards them to the subprocess. This change just exposes that feature to the end user.
|
r? @ehuss |
| @@ -586,7 +583,6 @@ struct FixArgs { | |||
| enabled_edition: Option<String>, | |||
| other: Vec<OsString>, | |||
There was a problem hiding this comment.
The args are now being pushed into this list.
|
I don't think we want to allow passing arbitrary args to rustc in the |
|
Fwiw I didn't base it on |
Prior to this change,
cargo fixhad no defacto method for passingadditional arguments down to rustc to use when generating warnings to be
fixed. We did implement a way to do so for clippy, but the hack was
inconsistent with the way all other sub commands get args for rustc,
where they take all args after the -- and pass them down.
This change removes the clippy args method as implemented earlier and
adds a new primary_unit_args passing mechanism which will work for
cargo fixandcargo fix --clippy.