-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wasm32-unknown-unknown by passing -c #1424
base: main
Are you sure you want to change the base?
Conversation
I don't know why it's removed, cc @madsmtm do you remember why? |
Traced this back to #1322. |
Perhaps we need to add an (internal) flag I generally agree that we should not attempt to link if we can avoid it, so we really should pass |
Hmm, actually, I think #1322 is wrong, and the real solution was #1379. CC @clubby789, can you check if this PR still works for you? |
Co-authored-by: Mads Marquart <[email protected]>
1379 does indeed fix the specific case, but 1322 is about preventing the general case (of linker-specific flags being incorrectly reported as supported). The |
But |
Fix #1423