Mac Catalyst: Read IPHONEOS_DEPLOYMENT_TARGET
from environment variable to support Clang 13
#678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Clang 13 removed the
x86_64-apple-ios13.0-macabi
target, where13.0
is hardcoded incc-rs
.Proof:
This PR is to remove this hardcoded version and read it from
IPHONEOS_DEPLOYMENT_TARGET
.Credits
@ehuss helped me found this reason: https://rust-lang.zulipchat.com/#narrow/stream/122651-general/topic/Update.20Mac.20Catalyst.20support.20for.20Clang.2013/near/280745037
How to test
In this commit imWildCat/BLAKE3@f7bfd77, I changed
cc-rs
to my branch.The build command and its output is like