Remove conditional compilation from mascot constants #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using #[cfg(...)] is not ideal here because it harms compile-time checking. For example, in order to be sure there isn't a type error, one must separately compile with and without "clippy" when making changes to the crate. Rust supports `if` in constants since version 1.46.0.
lcnr
reviewed
Mar 30, 2024
src/lib.rs
Outdated
| @@ -10,18 +10,17 @@ use unicode_width::UnicodeWidthStr; | |||
| // Constants! :D | |||
| const ENDSL: &[u8] = b"| "; | |||
| const ENDSR: &[u8] = b" |\n"; | |||
| #[cfg(not(feature = "clippy"))] | |||
| const FERRIS: &[u8] = br#" | |||
| const MASCOT: &[u8] = if !cfg!(feature = "clippy") { | |||
There was a problem hiding this comment.
consider flipping the branches instead of inverting the condition
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using #[cfg(...)] is not ideal here because it harms compile-time checking. For example, in order to be sure there isn't a type error, one must separately compile with and without "clippy" when making changes to the crate.
Rust supports
ifin constants since version 1.46.0 and it's a better fit for this code.