Include crate version for dev-dependencies #2614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that test dependencies are included in the Cargo.toml that is published to crates.io. As noted in the Cargo book: When a package is published, only dev-dependencies that specify a version will be included in the published crate. For most use cases, dev-dependencies are not needed when published, though some users (like OS packagers) may want to run tests within a crate, so providing a version if possible can still be beneficial. This is helpful for running tests in the Android Open Source Project, which uses crates.io as its source of truth, and prevents having to carry local patches. Test: cargo publish --dry-run Confirm that dev-dependencies are not listed in the resulting Cargo.toml.
|
Thanks for the PR. This is intentional (#2305), and cannot be accepted unless rust-lang/cargo#4242 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that test dependencies are included in the Cargo.toml
that is published to crates.io.
As noted in the Cargo book:
When a package is published, only dev-dependencies that specify a
version will be included in the published crate. For most use cases,
dev-dependencies are not needed when published, though some users
(like OS packagers) may want to run tests within a crate, so
providing a version if possible can still be beneficial.
This is helpful for running tests in the Android Open Source Project,
which uses crates.io as its source of truth, and prevents having to
carry local patches.
Test: cargo publish --dry-run
Confirm that dev-dependencies are listed in the resulting
Cargo.toml.