Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Warn on updates to compiler targets #313

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Warn on updates to compiler targets #313

merged 3 commits into from
Jun 24, 2021

Conversation

jhwgh1968
Copy link
Contributor

Closes #310.

This was simpler than I thought, but also has some reductions:

  • I did not know that multi-line messages were discouraged by the structure of the code. I decided to work within that, rather than refactor it just for this new message.
  • Given the pattern match I put in, I decided not to tag release notes to avoid false positives. I am not sure if, for example, some LLVM changes would trigger this warning as well.

This is ready for review, but am putting it in draft because the RFC I'm linking to is not yet merged. Once that happens (it seems to be a matter of when at this point), I will update it with the proper link on The Forge.

@jhwgh1968 jhwgh1968 marked this pull request as ready for review April 26, 2021 20:03
@jhwgh1968
Copy link
Contributor Author

jhwgh1968 commented Apr 26, 2021

Actually, it's not quite on the website yet. Based on rust-lang/rust#84583, I think the link will be:
https://doc.rust-lang.org/rustc/target_tier_policy.html

(Why can't see the button to make it a draft again? Oh well.)

@joshtriplett
Copy link
Member

joshtriplett commented Apr 27, 2021

It's on the site now: https://doc.rust-lang.org/nightly/rustc/target-tier-policy.html

Nightly will always have the latest version of the policy, so I'd suggest linking there.

jhwgh1968 and others added 2 commits April 28, 2021 00:26
@jhwgh1968
Copy link
Contributor Author

Apparently first-time contributors need a maintainer to run CI. Could I get a run please?

@jhwgh1968
Copy link
Contributor Author

Randomly pinging @oli-obk who committed recently, could I get a review and a CI run?

@jhwgh1968
Copy link
Contributor Author

Randomly pinging @pietroalbini who committed recently. Could I get a review and a CI run? This has been sitting for weeks.

@pietroalbini
Copy link
Member

Hmm, the button to approve the CI run is not appearing anymore... Let me try closing and reopening the PR.

@pietroalbini
Copy link
Member

Thanks!

@pietroalbini pietroalbini merged commit 2d25939 into rust-lang:master Jun 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn on change to targets
3 participants