Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make msqid_ds.__msg_cbytes public. #4301

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Make msqid_ds.__msg_cbytes public. #4301

merged 1 commit into from
Mar 7, 2025

Conversation

koutheir
Copy link
Contributor

@koutheir koutheir commented Mar 6, 2025

Make msqid_ds.__msg_cbytes public, making the field accessible. In C, struct msqid_ds is defined in <sys/msg.h>.

Closes #4300.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@koutheir
Copy link
Contributor Author

koutheir commented Mar 6, 2025

@tgross35, the CI failure is unrelated to my changes.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We often do this since the library doesn't really intend these fields be read, but there isn't much harm as long as it is understood that dunder fields tend to have no API guarantees.

CI is related to the recent rustup updates, I'll try to merge tomorrow.

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Mar 6, 2025
@tgross35 tgross35 enabled auto-merge March 7, 2025 03:35
@tgross35 tgross35 added this pull request to the merge queue Mar 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2025
@koutheir
Copy link
Contributor Author

koutheir commented Mar 7, 2025

@tgross35, again, the CI failure is still unrelated to my changes.

@tgross35
Copy link
Contributor

tgross35 commented Mar 7, 2025

I'm aware, we have had some flaky CI recently. #4306 may fix it.

@tgross35 tgross35 added this pull request to the merge queue Mar 7, 2025
Merged via the queue into rust-lang:main with commit 3e3f29c Mar 7, 2025
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

msqid_ds.__msg_cbytes is inaccessible
3 participants