Transition to 2018 edition #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
force-pushed
the
update-edition
branch
2 times, most recently
from
df3159f to
995e4df
Compare
| extern crate memchr; | ||
| extern crate pulldown_cmark; | ||
| extern crate regex; | ||
| extern crate serde; | ||
| #[macro_use] | ||
| extern crate serde_derive; |
There was a problem hiding this comment.
you can use macro imports and get rid of extern crates for these as well
There was a problem hiding this comment.
Thanks. But I think we should land it as is. Because we already transit
new edition. Also because I don't want to deal with missing macro importing
somewhere while trying to get rid of those extern crate.
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
* Transition to 2018 edition * Update Travis CI badge in README * Remove non-idiomatic `extern crate` lines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unaware that mdBook isn't in 2018 edition before.