Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an anchor to directly link to the -Zmiri-tree-borrows docs #4217

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

shepmaster
Copy link
Member

@shepmaster shepmaster commented Mar 3, 2025

This appears at #user-content--zmiri-tree-borrows when hosted on GitHub. On my repo

@RalfJung
Copy link
Member

RalfJung commented Mar 3, 2025

Is there some way we can leave a comment explaining why we need this? Does adding <!-- The playground links here --> work?

@shepmaster shepmaster force-pushed the tree-borrows-anchor branch from bd0a955 to b9cdfd9 Compare March 3, 2025 18:42
@saethlin
Copy link
Member

saethlin commented Mar 3, 2025

Is there some way we can leave a comment explaining why we need this?

This seems useful outside the playground, no? I wouldn't mind being able to link people to a specific flag in the README instead of the whole thing.

@RalfJung
Copy link
Member

RalfJung commented Mar 3, 2025

Yeah it does, but it looks odd to have a link for just one thing -- so I want to preemptively answer "does anyone care about this".

@RalfJung RalfJung enabled auto-merge March 3, 2025 18:52
@RalfJung RalfJung added this pull request to the merge queue Mar 3, 2025
Merged via the queue into rust-lang:master with commit 1120657 Mar 3, 2025
7 checks passed
@shepmaster shepmaster deleted the tree-borrows-anchor branch March 3, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants