Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Overloaded arithmetic and logical operators should take self and their arguments by value #118

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 79 additions & 0 deletions active/0000-by-value-overloaded-operators.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
- Start Date: 2014-06-13
- RFC PR #: (leave this empty)
- Rust Issue #: (leave this empty)

# Summary

Overloaded arithmetic and logical operators should take `self` and their arguments by value.

# Motivation

Expensive objects that support arithmetic and logical operations—bignums, primarily—would benefit from not having to copy whenever arithmetic is used. This particular case was one of the motivations for rvalue references in C++, in fact. One can work around it with `RefCell`, but it's a pain and introduces dynamic failures. The easiest way to fix this is to make the traits that define arithmetic and operators take `self` and any arguments by value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this is strictly more powerful than what we have today, because you can also implement it for references to a type!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Though I don't know if that will autoref...)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...stricly more powerful ... because you can implement it for references to a type..." -- @cmr: You don't really want that! Please see the rust-dev mailing list discussion ( http://article.gmane.org/gmane.comp.lang.rust.devel/10242 )


# Detailed design

The declarations of the traits `Add`, `Sub`, `Mul`, `Div`, `Rem`, `Neg`, `Not`, `BitAnd`, `BitOr`, `BitXor`, `Shl`, and `Shr` change to:

pub trait Add<RHS,Result> {
fn add(self, rhs: RHS) -> Result;
}

pub trait Sub<RHS,Result> {
fn sub(self, rhs: RHS) -> Result;
}

pub trait Mul<RHS,Result> {
fn mul(self, rhs: RHS) -> Result;
}

pub trait Div<RHS,Result> {
fn div(self, rhs: RHS) -> Result;
}

pub trait Rem<RHS,Result> {
fn rem(self, rhs: RHS) -> Result;
}

pub trait Neg<Result> {
fn neg(self) -> Result;
}

pub trait Not<Result> {
fn not(self) -> Result;
}

pub trait BitAnd<RHS,Result> {
fn bitand(self, rhs: RHS) -> Result;
}

pub trait BitOr<RHS,Result> {
fn bitor(self, rhs: RHS) -> Result;
}

pub trait BitXor<RHS,Result> {
fn bitxor(self, rhs: RHS) -> Result;
}

pub trait Shl<RHS,Result> {
fn shl(self, rhs: RHS) -> Result;
}

pub trait Shr<RHS,Result> {
fn shr(self, rhs: RHS) -> Result;
}

The `AutorefArgs` stuff in `typeck` will be removed; all overloaded operators will typecheck as though they were `DontAutorefArgs`.

# Drawbacks

Some use cases of `+`, such as string and array concatentation, may become more verbose. It is likely that many of the use cases of `+` today will be compatible with these new semantics.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately we do neither of those with the + operator.


# Alternatives

As an alternative, each of these operators could have two methods, one for by-reference and one for by-value. This adds complexity, however.

Not doing this will mean that the issues in "Motivation" will remain unsolved.

# Unresolved questions

None.