Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement assert_gt and assert_lt macros #2662

Closed
wants to merge 1 commit into from
Closed

Implement assert_gt and assert_lt macros #2662

wants to merge 1 commit into from

Conversation

ohsayan
Copy link

@ohsayan ohsayan commented Mar 16, 2019

This RFC implements two macros, assert_gt! and assert_lt! that makes writing tests easier, and provides a more standardized output for debugging, providing a similar output to the other assert macros (assert_eq! and assert_ne!)

@jonas-schievink
Copy link
Contributor

These were already proposed in #1662, has something changed in the meantime that means it should be reevaluated?

(also see #1653, which also discusses this)

@jonas-schievink jonas-schievink added T-libs-api Relevant to the library API team, which will review and decide on the RFC. A-macros-libstd Proposals that introduce new standard library macros A-assertions Proposals relating to assertions. labels Mar 16, 2019
@Centril Centril added the A-compare Proposals relating to comparisons. label Mar 16, 2019
@ohsayan
Copy link
Author

ohsayan commented Mar 17, 2019 •
edited
Loading

These were already proposed in #1662, has something changed in the meantime that means it should be reevaluated?

(also see #1653, which also discusses this)

It was to be implemented, but the PR (#1662) was closed. If you do note, that @brson mentioned that we can maybe implement the assert_gt! and assert_lt macros

@ohsayan
Copy link
Author

ohsayan commented Mar 17, 2019

Looks like this should be closed as these macros may not be used at all, hence I'm closing this PR

@ohsayan ohsayan closed this Mar 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-assertions Proposals relating to assertions. A-compare Proposals relating to comparisons. A-macros-libstd Proposals that introduce new standard library macros T-libs-api Relevant to the library API team, which will review and decide on the RFC.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ohsayan @jonas-schievink @Centril