Add allow_attribute lint
#10481
Merged
Add allow_attribute lint
#10481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
blyxyas
force-pushed
the
allow_attribute
branch
from
f5a2e1d to
0f1474e
Compare
xFrednet
reviewed
Mar 11, 2023
xFrednet
reviewed
Mar 15, 2023
xFrednet
force-pushed
the
allow_attribute
branch
from
386fa4b to
1cab0cb
Compare
xFrednet
approved these changes
Mar 16, 2023
|
This version looks good to me, thank you for implementing this lint! I like it :) There was still a small formatting NIT where I don't think it was worth it to leave a comment about. I fixed up your last commit. Hope that's okay with you :) @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
This was referenced Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10468
changelog: new lint: [
allow_attributes]#10481