Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -Z no-trans support? #281

Closed
ehuss opened this issue May 15, 2018 · 1 comment · Fixed by #286
Closed

Remove -Z no-trans support? #281

ehuss opened this issue May 15, 2018 · 1 comment · Fixed by #286

Comments

@ehuss
Copy link

ehuss commented May 15, 2018

The -Z no-trans option will be soon renamed to -Z no-codegen (see rust-lang/rust#50615). There is still legacy support for the on-save checking to use this mode instead of cargo check. I'd prefer just to remove support for no-trans, since I don't think there is a good reason to use it nowadays. Alternatively, we can check the rustc version and use the new flag if anyone actually still wants it.

Rust Enhanced Version

v2.11.0

@eddyb
Copy link
Member

eddyb commented May 16, 2018

IMO there's no technical reason for using -Zno-{trans,codegen} instead of cargo check.

ehuss added a commit to ehuss/sublime-rust that referenced this issue May 28, 2018
- Remove support for -Z no-trans on-save checking (fixes rust-lang#281).
- Update some tests for latest nightly.
- Pin nightly and clippy to a known-good version for Travis.  This should
  ensure that minor issues don't cause unrelated PRs to fail.  This also
  configures the beta/nightly jobs to allow failure.  I have a cron job on my
  own repository set up so I will be notified whenever things break, and I'll
  send PRs when necessary.
jasonwilliams pushed a commit that referenced this issue Jun 5, 2018
- Remove support for -Z no-trans on-save checking (fixes #281).
- Update some tests for latest nightly.
- Pin nightly and clippy to a known-good version for Travis.  This should
  ensure that minor issues don't cause unrelated PRs to fail.  This also
  configures the beta/nightly jobs to allow failure.  I have a cron job on my
  own repository set up so I will be notified whenever things break, and I'll
  send PRs when necessary.
jimenezrick added a commit to jimenezrick/ale that referenced this issue Aug 10, 2018
The rust compiler renamed the option '-Z no-trans' to '-Z no-codegen'.

rust-lang/rust-enhanced#281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants