Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Err from thread should implement Show #21291

Closed
ciphergoth opened this issue Jan 17, 2015 · 1 comment · Fixed by #24254
Closed

Err from thread should implement Show #21291

ciphergoth opened this issue Jan 17, 2015 · 1 comment · Fixed by #24254

Comments

@ciphergoth
Copy link
Contributor

It's strange that you can't do Thread::spawn(foo).join().unwrap(), but it's because Box<core::any::Any + Send> doesn't implement Show. An un-Showable Err seems like an undesirable thing to have around, is it necessary in this case?
@steveklabnik
Copy link
Member

This is Debug now.

@alexcrichton alexcrichton mentioned this issue Feb 23, 2015
Closed
aturon added a commit to aturon/rust that referenced this issue Apr 10, 2015
@aturon
Ensure that .join().unwrap() works
d69ec5e 
Make `Box<Any + Send>` implement `Debug`.

Fixes rust-lang#21291
@aturon aturon mentioned this issue Apr 10, 2015
Merged
aturon added a commit to aturon/rust that referenced this issue Apr 10, 2015
@aturon
Ensure that .join().unwrap() works
76d468a 
Makes `Any + Send` implement `Debug`.

Fixes rust-lang#21291
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 10, 2015
@Manishearth
Rollup merge of rust-lang#24254 - aturon:join-handle-debug, r=alexcri…
a7fd8c8 
…chton

Make `Box<Any + Send>` implement `Debug`.

Fixes rust-lang#21291
Manishearth added a commit to Manishearth/rust that referenced this issue Apr 10, 2015
@Manishearth
Rollup merge of rust-lang#24254 - aturon:join-handle-debug, r=alexcri…
8fae6a0 
…chton

 Make `Box<Any + Send>` implement `Debug`.

Fixes rust-lang#21291
bors added a commit that referenced this issue Apr 11, 2015
@bors
Auto merge of #24254 - aturon:join-handle-debug, r=alexcrichton
3a82753 
Make `Box<Any + Send>` implement `Debug`.

Fixes #21291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ensure that .join().unwrap() works aturon/rust
3 participants
@steveklabnik @ciphergoth @kmcallister