Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature-gate #[no_std] #21833

Closed
kmcallister opened this issue Feb 1, 2015 · 2 comments · Fixed by #21988
Closed

Feature-gate #[no_std] #21833

kmcallister opened this issue Feb 1, 2015 · 2 comments · Fixed by #21988
Assignees
@kmcallister
Labels
A-syntaxext Area: Syntax extensions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-medium Medium priority
Milestone
1.0 beta

Comments

@kmcallister
Copy link
Contributor

It breaks various things at the syntax layer, e.g. #21827, #16803, #14342. I plan to fix those before the beta but I'm not sure what other issues there are.
@kmcallister kmcallister added A-syntaxext Area: Syntax extensions I-nominated labels Feb 1, 2015
@sfackler
Copy link
Member

sfackler commented Feb 1, 2015

If we feature gate this, it'd be nice to move std injection either into expansion or after it. Right now you can't do #![cfg_attr(feature = "foo", no_std)], which means that crates that want to compile both in normal and no_std contexts have to use no_std. For example, take rust-phf: rust-phf/rust-phf@24555b1.

@larsbergstrom larsbergstrom mentioned this issue Feb 3, 2015
Closed
1 task
@alexcrichton alexcrichton mentioned this issue Feb 3, 2015
Closed
@brson brson added the E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. label Feb 5, 2015
@pnkfelix
Copy link
Member

pnkfelix commented Feb 5, 2015

1.0 beta

@pnkfelix pnkfelix added this to the 1.0 beta milestone Feb 5, 2015
@pnkfelix pnkfelix added P-medium Medium priority and removed I-nominated labels Feb 5, 2015
@kmcallister kmcallister self-assigned this Feb 5, 2015
kmcallister added a commit to kmcallister/rust that referenced this issue Feb 7, 2015
@kmcallister
Feature-gate #![no_std]
d788588 
Fixes rust-lang#21833.

[breaking-change]
bors added a commit that referenced this issue Feb 8, 2015
@bors
Auto merge of #21988 - kmcallister:no-std, r=sfackler
74b8740 
Fixes #21833.

[breaking-change]

r? @alexcrichton 

The tests in #21912 will also need `#[feature(no_std)]`. If you're okay with both PRs, I can merge and test them.
dlrobertson pushed a commit to dlrobertson/rust that referenced this issue Nov 29, 2018
@kmcallister @Manishearth
Feature-gate #![no_std]
5ced430 
Fixes rust-lang#21833.

[breaking-change]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmcallister kmcallister

Labels
A-syntaxext Area: Syntax extensions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. P-medium Medium priority
Projects
None yet
Milestone
1.0 beta
Development

Successfully merging a pull request may close this issue.

Feature-gate #![no_std] and fix most syntax extensions kmcallister/rust
4 participants
@brson @pnkfelix @kmcallister @sfackler