Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning false positive with #[derive(Hash)] in nightly #32292

Closed
mcarton opened this issue Mar 16, 2016 · 0 comments · Fixed by #32294
Closed

Warning false positive with #[derive(Hash)] in nightly #32292

mcarton opened this issue Mar 16, 2016 · 0 comments · Fixed by #32294

Comments

@mcarton
Copy link
Member

mcarton commented Mar 16, 2016

The following unused_variables warning just appeared in Clippy with the last nightly:

% cat a.rs 
#[derive(Hash)]
struct Foo;

fn main() { let _ = Foo; }
% rustc a.rs 
a.rs:1:10: 1:14 warning: unused variable: `arg_0`, #[warn(unused_variables)] on by default
a.rs:1 #[derive(Hash)]
                ^~~~
a.rs:1:10: 1:14 note: in this expansion of #[derive_Hash] (defined in a.rs)
% rustc --version
rustc 1.9.0-nightly (c66d2380a 2016-03-15)
bors added a commit that referenced this issue Mar 17, 2016
Re-add double underscores in derive (fixes #32292)

@durka, sanity-check, please?

<s>Don't merge this yet, I need to add a test and test it locally.</s>

ready for review
@bors bors closed this as completed in 76b3523 Mar 17, 2016
durka pushed a commit to durka/rust that referenced this issue Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant