Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error! and debug! escape single quotes strangely #3752

Closed
catamorphism opened this issue Oct 13, 2012 · 3 comments
Closed

error! and debug! escape single quotes strangely #3752

catamorphism opened this issue Oct 13, 2012 · 3 comments
Labels
A-syntaxext Area: Syntax extensions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@catamorphism
Copy link
Contributor

fn main() {
    error!("It's time for dinner!");
}

prints

rust: ~"It\'s time for dinner!"

io::println prints the correct output. Not a big deal, just a little strange.

@emberian
Copy link
Member

emberian commented Jul 3, 2013

It's even worse now that it passes its argument to fmt!:

rust: ~"\"It\\\'s time for dinner!\""

@alexcrichton
Copy link
Member

Huh, it's not instantly godawful with format!

rusti> format!("It's time for dinner!")
~"It\'s time for dinner!"

Agreed though that it still shouldn't escape the single quote.

@alexcrichton
Copy link
Member

I believe that this is closed with a combination of #9005, #9046, and format!/error2!.

I'm going to close this because there's not really an issue to track the transition from error => error2, but it's high on my todo list as soon as a snapshot becomes available.

bors pushed a commit to rust-lang-ci/rust that referenced this issue May 15, 2021
RalfJung pushed a commit to RalfJung/rust that referenced this issue Aug 22, 2024
Implement SHA256 SIMD intrinsics on x86

Disclaimer: this is my first contribution to `miri`'s code. It's quite possible I'm missing something. This code works but may not be the cleanest/best possible.

It'd be useful to be able to verify code implementing SHA256 using SIMD since such code is a bit more complicated and at some points requires use of pointers. Until now `miri` didn't support x86 SHA256 intrinsics. This commit implements them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-syntaxext Area: Syntax extensions E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants