Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should be able to implement Drop on enums #6250

Closed
thestinger opened this issue May 5, 2013 · 11 comments
Closed

should be able to implement Drop on enums #6250

thestinger opened this issue May 5, 2013 · 11 comments
Labels
A-destructors Area: Destructors (`Drop`, …) A-type-system Area: Type system P-medium Medium priority

Comments

@thestinger
Copy link
Contributor

No description provided.

@jdm
Copy link
Contributor

jdm commented May 7, 2013

Nominating for some maturity milestone.

@metajack
Copy link
Contributor

metajack commented May 7, 2013

It seems like feature complete would be appropriate.

@graydon
Copy link
Contributor

graydon commented May 9, 2013

accepted for feature-complete milestone

@catamorphism
Copy link
Contributor

(bug triage) If this is going to be on a milestone I guess it should be feature-complete. I'm wondering whether it's necessary, though.

@emberian
Copy link
Member

Jeez. What an obvious hole that I have never seen before. Is there a good reason this is disallowed?

@pnkfelix
Copy link
Member

Agreed that this be allowed. But it can be added backwards-compatibly.

(it seems to be hitting an ICE currently, which we should resolve before 1.0 if this feature itself does not get added.)

P-high, not 1.0.

@ghost
Copy link

ghost commented Jun 24, 2014

I have a branch that implements this but maybe it should wait until the drop flag dust settles (if it does?).

@thestinger
Copy link
Contributor Author

@jakub-: I don't think you need to wait. It doesn't seem like it would have an impact of drop flag removal as it's the same mechanism as struct uses.

@retep998
Copy link
Member

Did #15272 fix this?

@ghost
Copy link

ghost commented Jul 24, 2014

Yes, this can be closed now.

@alexcrichton
Copy link
Member

Thanks @jakub-!

flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 3, 2020
flip1995 pushed a commit to flip1995/rust that referenced this issue Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-destructors Area: Destructors (`Drop`, …) A-type-system Area: Type system P-medium Medium priority
Projects
None yet
Development

No branches or pull requests

9 participants