-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should be able to implement Drop on enums #6250
Comments
Nominating for some maturity milestone. |
It seems like feature complete would be appropriate. |
accepted for feature-complete milestone |
(bug triage) If this is going to be on a milestone I guess it should be feature-complete. I'm wondering whether it's necessary, though. |
Jeez. What an obvious hole that I have never seen before. Is there a good reason this is disallowed? |
Agreed that this be allowed. But it can be added backwards-compatibly. (it seems to be hitting an ICE currently, which we should resolve before 1.0 if this feature itself does not get added.) P-high, not 1.0. |
I have a branch that implements this but maybe it should wait until the drop flag dust settles (if it does?). |
@jakub-: I don't think you need to wait. It doesn't seem like it would have an impact of drop flag removal as it's the same mechanism as |
Did #15272 fix this? |
Yes, this can be closed now. |
Thanks @jakub-! |
Fixes rust-lang#6250 Fixes rust-lang#6251 Fixes rust-lang#6252 Fixes rust-lang#6255 Fixes rust-lang#6256
add a couple of ICE testcases Fixes rust-lang#6250 Fixes rust-lang#6251 Fixes rust-lang#6252 Fixes rust-lang#6255 Fixes rust-lang#6256 changelog: none
No description provided.
The text was updated successfully, but these errors were encountered: