Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NaN() and is_NaN() method names lowercase #9319

Closed
chris-morgan opened this issue Sep 19, 2013 · 0 comments · Fixed by #9321
Closed

Make NaN() and is_NaN() method names lowercase #9319

chris-morgan opened this issue Sep 19, 2013 · 0 comments · Fixed by #9321

Comments

@chris-morgan
Copy link
Member

For consistency in naming convention:

  • Float::NaN() should be named Float::nan();
  • Float.is_NaN() should be named Float.is_nan(); and
  • NumStrConv::NaN() should be named NumStrConv::nan().

(I'm am at present doing this.)
@chris-morgan chris-morgan mentioned this issue Sep 19, 2013
Merged
bors added a commit that referenced this issue Sep 20, 2013
@bors
auto merge of #9321 : chris-morgan/rust/lowercase-nan-methods, r=brson
ccb80ab 
This is for consistency in naming conventions.

- ``std::num::Float::NaN()`` is changed to ``nan()``;
- ``std::num::Float.is_NaN()`` is changed to ``is_nan()``; and
- ``std::num::strconv::NumStrConv::NaN()`` is changed to ``nan()``.

Fixes #9319.
@bors bors closed this as completed in d9874c0 Sep 20, 2013
flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 7, 2024
@J-ZhengLi
add test cases for rust-lang#9319
dde2552
flip1995 pushed a commit to flip1995/rust that referenced this issue Mar 7, 2024
@bors
Auto merge of rust-lang#12393 - J-ZhengLi:issue9413, r=dswij
f75d8c7 
fix [`derive_partial_eq_without_eq`] FP on trait projection

fixes: rust-lang#9413 rust-lang#9319

---

changelog: fix [`derive_partial_eq_without_eq`] FP on trait projection

Well, this is awkward, it works but I don't understand why, why `clippy_utils::ty::implements_trait` couldn't detects the existance of `Eq` trait, even thought it's obviously present in the derive attribute.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename the NaN and is_NaN methods to lowercase. chris-morgan/rust
1 participant
@chris-morgan