Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate item_foreign_type to Askama #112005

Merged
merged 1 commit into from
May 28, 2023
Merged

Migrate item_foreign_type to Askama #112005

merged 1 commit into from
May 28, 2023

Conversation

sladyn98
Copy link
Contributor

@sladyn98 sladyn98 commented May 26, 2023 •
edited
Loading

This PR continues the migration of print_item.rs functions to Askama. This piece of work migrates the function item_foreign_type

Refers #108868

@rustbot
Copy link
Collaborator

rustbot commented May 26, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jsha (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels May 26, 2023
@sladyn98
Copy link
Contributor Author

@GuillaumeGomez Migrated another function

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member

Please fix the CI error, squash your commits and then I'll approve it.

@sladyn98 sladyn98 force-pushed the item-foreign-types branch from abc3df6 to cf652e8 Compare May 27, 2023 19:16
@sladyn98
Migrate to Askama
a7329cd 
Fix formatting

Fix CI
@sladyn98 sladyn98 force-pushed the item-foreign-types branch from cf652e8 to a7329cd Compare May 27, 2023 19:20
@sladyn98
Copy link
Contributor Author

Thanks, fixed the CI and squashed the commits.

@sladyn98 sladyn98 requested a review from GuillaumeGomez May 27, 2023 19:21
@GuillaumeGomez
Copy link
Member

r=me once CI pass

@sladyn98
Copy link
Contributor Author

sladyn98 commented May 27, 2023 •
edited
Loading

@bors r=@GuillaumeGomez
Oh not enough privileges : ) haha

@bors
Copy link
Contributor

bors commented May 27, 2023

@sladyn98: 🔑 Insufficient privileges: Not in reviewers

@GuillaumeGomez
Copy link
Member

Ah right, I keep forgetting about that...

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 27, 2023

📌 Commit a7329cd has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 27, 2023
@fee1-dead fee1-dead mentioned this pull request May 28, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 28, 2023
@bors
Auto merge of rust-lang#112028 - fee1-dead-contrib:rollup-4xxzxd0, r=…
ddad057 
…fee1-dead

Rollup of 2 pull requests

Successful merges:

 - rust-lang#110081 (bump `thiserror` to use syn 2.0)
 - rust-lang#112005 (Migrate `item_foreign_type` to Askama )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5a19113 into rust-lang:master May 28, 2023
@rustbot rustbot added this to the 1.72.0 milestone May 28, 2023
@clubby789 clubby789 mentioned this pull request Jun 10, 2024
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@jsha jsha

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
6 participants
@sladyn98 @rustbot @rust-log-analyzer @GuillaumeGomez @bors @jsha