Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify documentation regarding +bundle linkage modifier #112384

Closed
wants to merge 2 commits into from
Closed

Clarify documentation regarding +bundle linkage modifier #112384

wants to merge 2 commits into from

Conversation

In-line
Copy link
Contributor

@In-line In-line commented Jun 7, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2023
@In-line In-line mentioned this pull request Jun 7, 2023
Closed
@GuillaumeGomez
Copy link
Member

I *think* you might know more about this @jyn514 ? Assigning you but don't hesitate to re-roll.

r? @jyn514

@rustbot rustbot assigned jyn514 and unassigned GuillaumeGomez Jun 7, 2023
@jyn514
Copy link
Member

jyn514 commented Jun 7, 2023

r? compiler

@rustbot rustbot assigned fee1-dead and unassigned jyn514 Jun 7, 2023
@jyn514
Copy link
Member

jyn514 commented Jun 7, 2023

cc @fee1-dead

@fee1-dead
Copy link
Member

I am not familiar with this.

r? compiler

@rustbot rustbot assigned davidtwco and unassigned fee1-dead Jun 7, 2023
petrochenkov
petrochenkov reviewed Jun 7, 2023
View reviewed changes
@In-line In-line requested a review from petrochenkov June 7, 2023 17:28
@In-line
Copy link
Contributor Author

In-line commented Jun 7, 2023

Github for some reason, doesn't want to show this commit in PR: In-line@6431df9

@In-line In-line changed the title Clarify documentation regarding +bundled linkage modifier Clarify documentation regarding +bundle linkage modifier Jun 7, 2023
@In-line In-line requested a review from davidtwco June 27, 2023 15:03
@petrochenkov
Copy link
Contributor

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned davidtwco Jul 26, 2023
@petrochenkov
Copy link
Contributor

Things became a bit more complex after #111698.

Unspecified kind can now mean either dylib or static depending on the situation.
If dylib is chosen (the usual case), then the used modifiers will be +as-needed.
If static is chosen (static binary case), then the used modifiers will be -bundle,-whole-archive.

petrochenkov
petrochenkov reviewed Jul 26, 2023
View reviewed changes
src/doc/rustc/src/command-line-arguments.md
@@ -62,11 +62,15 @@ attribute or on the command-line, it will link a dynamic library if available,
otherwise it will use a static library. If the kind is specified on the
command-line, it will override the kind specified in a `link` attribute.

If you don't specify `KIND`, no linkage modifiers will be applied.
For instance, [`+bundle` linkage modifier][bundle-modifier] won't be used in conjunction with static library by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course it won't be used, because there won't be any static library.
When this PR was submitted, unspecified kind always meant dylib.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 26, 2023
@JohnCSimon
Copy link
Member

@In-line

ping from triage - can you post your status on this PR? There hasn't been an update in a few months. Thanks!

FYI: when a PR is ready for review, send a message containing
@rustbot ready to switch to S-waiting-on-review so the PR is in the reviewer's backlog.

@Dylan-DPC
Copy link
Member

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

@Dylan-DPC Dylan-DPC closed this Feb 10, 2024
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@davidtwco davidtwco Awaiting requested review from davidtwco

Assignees

@petrochenkov petrochenkov

Labels
S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@In-line @rustbot @GuillaumeGomez @jyn514 @fee1-dead @petrochenkov @JohnCSimon @Dylan-DPC @davidtwco