rustc: Move crate_types and stable_crate_id from Session to GlobalCtxt
#114622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @TaKO8Ki (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
|
r? @oli-obk |
|
r=me with fallout fixed |
bjorn3
reviewed
Aug 8, 2023
Removes a piece of mutable state. Follow up to rust-lang#114578.
Removes a piece of mutable state. Follow up to rust-lang#114578.
|
@rustbot ready |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2023
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#114599 (Add impl trait declarations to SMIR) - rust-lang#114622 (rustc: Move `crate_types` and `stable_crate_id` from `Session` to `GlobalCtxt`) - rust-lang#114662 (Unlock trailing where-clauses for lazy type aliases) - rust-lang#114693 (Remove myself from the review rotation) - rust-lang#114694 (make the provisional cache slightly less broken) - rust-lang#114705 (Add spastorino to mailmap) - rust-lang#114712 (Fix a couple of bad comments) r? `@ghost` `@rustbot` modify labels: rollup
petrochenkov
added a commit
to petrochenkov/rust
that referenced
this pull request
Aug 11, 2023
Removes two pieces of mutable state. Follow up to rust-lang#114622.
|
This seems to be part of a general push to remove interior mutability from |
|
Ah I see. :) I was just curious why interior mutability in |
|
Interior mutability in |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 13, 2023
rustc: Move `features` from `Session` to `GlobalCtxt` Removes one more piece of mutable state. Follow up to rust-lang#114622. The rule I used for passing feature in function signatures: - if a crate already depends on `rustc_middle`, then `Session` is replaced with `TyCtxt` - otherwise session and features are passed as a pair `sess: &Session, features: &Features` The code in `rustc_lint` is ultimately used for implementing a trait from `rustc_expand`, so it also doesn't use tcx despite the dependency on `rustc_middle`.
4 tasks
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Sep 6, 2023
rustc: Move `crate_types` and `stable_crate_id` from `Session` to `GlobalCtxt` Removes two pieces of mutable state. Follow up to rust-lang#114578.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes two pieces of mutable state.
Follow up to #114578.