-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary unit binding #121224
Remove unnecessary unit binding #121224
Conversation
Signed-off-by: hi-rustin <[email protected]>
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
@bors r+ rollup Not sure, but seems likely to be fine. I don't see any particularly interesting other similar cases. |
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118569 (Move `OsStr::slice_encoded_bytes` validation to platform modules) - rust-lang#121067 (make "invalid fragment specifier" translatable) - rust-lang#121224 (Remove unnecessary unit binding) - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`) - rust-lang#121257 (remove extraneous text from example config) - rust-lang#121260 (Remove const_prop.rs) - rust-lang#121266 (Add uncontroversial syscall doc aliases to std docs) r? `@ghost` `@rustbot` modify labels: rollup
Kind of static assert, like rust/compiler/rustc_index/src/lib.rs Lines 33 to 38 in c9c83cc
|
As far as I know, there are different ways to do a static assert in rust:
Are there any guidelines about choosing between them? |
Rollup merge of rust-lang#121224 - hi-rustin:rustin-patch-unit-binding, r=Mark-Simulacrum Remove unnecessary unit binding It appears that the unit binding is not necessary at this time. However, I am unsure of its importance in the past. Please let me know if it is unsafe to remove.
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#118569 (Move `OsStr::slice_encoded_bytes` validation to platform modules) - rust-lang#121067 (make "invalid fragment specifier" translatable) - rust-lang#121224 (Remove unnecessary unit binding) - rust-lang#121247 (Add help to `hir_analysis_unrecognized_intrinsic_function`) - rust-lang#121257 (remove extraneous text from example config) - rust-lang#121260 (Remove const_prop.rs) - rust-lang#121266 (Add uncontroversial syscall doc aliases to std docs) r? `@ghost` `@rustbot` modify labels: rollup
It appears that the unit binding is not necessary at this time. However, I am unsure of its importance in the past. Please let me know if it is unsafe to remove.