try ColdFuncOpt variants for PGO

[klensy]

r? @ghost

[Kobzol]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 9b339a8 with merge 46419cf...

[bors]

☀️ Try build successful - checks-actions
Build commit: 46419cf (46419cf3f34f56fa93bc3d2a2b70f08e96186d54)

[rust-timer]

Finished benchmarking commit (46419cf): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.4%]	85
Regressions ❌ (secondary)	0.3%	[0.0%, 1.2%]	46
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	2
All ❌✅ (primary)	0.2%	[0.1%, 0.4%]	85

Max RSS (memory usage)

Results (primary -0.7%, secondary -0.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.0%	[2.0%, 2.0%]	2
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-1.5%	[-1.9%, -1.1%]	3
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Cycles

Results (primary 1.5%, secondary 2.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[0.8%, 2.6%]	12
Regressions ❌ (secondary)	2.1%	[1.1%, 2.7%]	17
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.5%	[0.8%, 2.6%]	12

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.103s -> 782.262s (0.28%)
Artifact size: 335.34 MiB -> 333.59 MiB (-0.52%)

[klensy]

That was ColdFuncOpt::OptSize, let's try ColdFuncOpt::MinSize.

[Kobzol]

@bors try @rust-timer queue

[bors]

⌛ Trying commit b985925 with merge d6be483...

[bors]

☀️ Try build successful - checks-actions
Build commit: d6be483 (d6be483de3b454704da98ffcf276ac8ce9b2831d)

[rust-timer]

Finished benchmarking commit (d6be483): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 1.1%]	148
Regressions ❌ (secondary)	0.5%	[0.0%, 1.3%]	90
Improvements ✅ (primary)	-0.5%	[-0.5%, -0.5%]	1
Improvements ✅ (secondary)	-0.5%	[-0.6%, -0.2%]	15
All ❌✅ (primary)	0.4%	[-0.5%, 1.1%]	149

Max RSS (memory usage)

Results (secondary 1.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.9%	[0.8%, 2.5%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (primary 0.9%, secondary -0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.9%	[0.7%, 1.1%]	11
Regressions ❌ (secondary)	2.6%	[2.4%, 2.8%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.3%, -2.8%]	2
All ❌✅ (primary)	0.9%	[0.7%, 1.1%]	11

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.98s -> 781.965s (0.25%)
Artifact size: 335.38 MiB -> 335.93 MiB (0.17%)

[klensy]

Weird that minsize bigger than optsize, but this can be affected by

rust/src/tools/opt-dist/src/bolt.rs

Lines 78 to 81 in 4b198d6

	// FIXME(kobzol): try to re-enable this once BOLT in-place rewriting is merged or after
	// we bump LLVM.
	// Try to reuse old text segments to reduce binary size
	// .arg("--use-old-text")

While i enabled optimization for rust, i forgot to enable it for libllvm :-(