Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test that relies on error language #137117

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

ChrisDenton
Copy link
Member

@ChrisDenton ChrisDenton commented Feb 16, 2025

We shouldn't care about the OS error message text in this test.

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2025

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 16, 2025
@Noratrieb
Copy link
Member

@bors r=fmease,Noratrieb

@bors
Copy link
Contributor

bors commented Feb 16, 2025

📌 Commit 8ae3ca9 has been approved by fmease,Noratrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2025
@fmease
Copy link
Member

fmease commented Feb 16, 2025

Fixes #137116?

@Noratrieb
Copy link
Member

oh yeah

@ChrisDenton
Copy link
Member Author

Fixes #137116?

I think @crlf0710 is looking for a more general solution so that should still be discussed.

@jieyouxu
Copy link
Member

I think @crlf0710 is looking for a more general solution so that should still be discussed.

Better as a separate issue, this is still an improvement in the meantime to address that specific test.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 16, 2025
…oratrieb

Fix test that relies on error language

We shouldn't care about the OS error message text in this test.
@ChrisDenton ChrisDenton linked an issue Feb 16, 2025 that may be closed by this pull request
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 16, 2025
…oratrieb

Fix test that relies on error language

We shouldn't care about the OS error message text in this test.
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#125087 (Optimize `Seek::stream_len` impl for `File`)
 - rust-lang#136986 (Apply unsafe_op_in_unsafe_fn to the standard library)
 - rust-lang#137012 (add docs and ut for bootstrap util cc-detect)
 - rust-lang#137072 (Load all builtin targets at once instead of one by one in check-cfg)
 - rust-lang#137102 (Rework `name_regions` to not rely on reverse scc graph for non-member-constrain usages)
 - rust-lang#137112 (Don't project into `NonNull` when dropping a `Box`)
 - rust-lang#137114 (Add an example for `std::error::Error`)
 - rust-lang#137117 (Fix test that relies on error language)
 - rust-lang#137119 (fix broken `x {doc, build} core`)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 16, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136986 (Apply unsafe_op_in_unsafe_fn to the standard library)
 - rust-lang#137012 (add docs and ut for bootstrap util cc-detect)
 - rust-lang#137072 (Load all builtin targets at once instead of one by one in check-cfg)
 - rust-lang#137102 (Rework `name_regions` to not rely on reverse scc graph for non-member-constrain usages)
 - rust-lang#137112 (Don't project into `NonNull` when dropping a `Box`)
 - rust-lang#137114 (Add an example for `std::error::Error`)
 - rust-lang#137117 (Fix test that relies on error language)
 - rust-lang#137119 (fix broken `x {doc, build} core`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7374439 into rust-lang:master Feb 17, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Feb 17, 2025
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 17, 2025
Rollup merge of rust-lang#137117 - ChrisDenton:error-lang, r=fmease,Noratrieb

Fix test that relies on error language

We shouldn't care about the OS error message text in this test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test case uses locale-dependent output
6 participants