Move fs into sys
#137650
Merged
Move fs into sys
#137650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
O-hermit
This comment has been minimized.
This comment has been minimized.
thaliaarchi
force-pushed
the
move-fs-pal
branch
from
32992dc to
5a2405a
Compare
This comment has been minimized.
This comment has been minimized.
thaliaarchi
force-pushed
the
move-fs-pal
branch
from
5a2405a to
146f085
Compare
This comment has been minimized.
This comment has been minimized.
thaliaarchi
force-pushed
the
move-fs-pal
branch
from
146f085 to
9f84dda
Compare
|
The Miri subtree was changed cc @rust-lang/miri |
RalfJung
reviewed
Feb 27, 2025
thaliaarchi
force-pushed
the
move-fs-pal
branch
from
9f84dda to
432a23f
Compare
RalfJung
reviewed
Feb 27, 2025
thaliaarchi
force-pushed
the
move-fs-pal
branch
2 times, most recently
from
195fc44 to
02a3d60
Compare
|
Miri changes LGTM :) |
This comment has been minimized.
This comment has been minimized.
thaliaarchi
force-pushed
the
move-fs-pal
branch
from
02a3d60 to
195fc44
Compare
|
☔ The latest upstream changes (presumably #137855) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #138155) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #138208) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 9, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#122790 (Apply dllimport in ThinLTO) - rust-lang#137650 (Move `fs` into `sys`) - rust-lang#138228 (Use `disjoint_bitor` inside `borrowing_sub`) - rust-lang#138233 (Windows: Don't link std (and run-make) against advapi32, except on win7) - rust-lang#138253 (Continue to check attr if meet empty repr for adt) - rust-lang#138263 (Fix `repr128-dwarf` test) - rust-lang#138276 (Lazy load NtOpenFile for UWP) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 9, 2025
Rollup merge of rust-lang#137650 - thaliaarchi:move-fs-pal, r=Noratrieb Move `fs` into `sys` Move platform definitions of `fs` into `std::sys`, as part of rust-lang#117276. cc `@joboet`
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move platform definitions of
fsintostd::sys, as part of #117276.cc @joboet