Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize const_char_classify, const_sockaddr_setters #138129

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 6, 2025

FCP for const_char_classify: #132241
FCP for const_sockaddr_setters: #131714

Fixes #132241
Fixes #131714

Cc @rust-lang/wg-const-eval

@rustbot
Copy link
Collaborator

rustbot commented Mar 6, 2025

r? @Amanieu

rustbot has assigned @Amanieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Mar 6, 2025
@rust-log-analyzer

This comment has been minimized.

@tgross35
Copy link
Contributor

tgross35 commented Mar 6, 2025

Fyi const_copy_from_slice is also in #138098

@RalfJung RalfJung force-pushed the stabilize-const-things branch from bece15a to a123d90 Compare March 6, 2025 21:55
@RalfJung
Copy link
Member Author

RalfJung commented Mar 6, 2025

Why does someone open a PR for a stabilization they did not initiate without notifying people in the tracking issue :/

@RalfJung RalfJung force-pushed the stabilize-const-things branch from a123d90 to 8f8c7fc Compare March 6, 2025 21:58
@RalfJung RalfJung changed the title Stabilize const_char_classify, const_sockaddr_setters, const_copy_from_slice Stabilize const_char_classify, const_sockaddr_setters Mar 6, 2025
@tgross35
Copy link
Contributor

tgross35 commented Mar 6, 2025

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 6, 2025

📌 Commit 8f8c7fc has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2025
@tgross35 tgross35 assigned tgross35 and unassigned Amanieu Mar 6, 2025
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Mar 7, 2025
…=tgross35

Stabilize const_char_classify, const_sockaddr_setters

FCP for const_char_classify: rust-lang#132241
FCP for const_sockaddr_setters: rust-lang#131714

Fixes rust-lang#132241
Fixes rust-lang#131714

Cc `@rust-lang/wg-const-eval`
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
…kingjubilee

Rollup of 12 pull requests

Successful merges:

 - rust-lang#136667 (Revert vita's c_char back to i8)
 - rust-lang#136780 (std: move stdio to `sys`)
 - rust-lang#137107 (Override default `Write` methods for cursor-like types)
 - rust-lang#137363 (compiler: factor Windows x86-32 ABI impl into its own file)
 - rust-lang#137528 (Windows: Fix error in `fs::rename` on Windows 1607)
 - rust-lang#137537 (Prevent `rmake.rs` from using unstable features, and fix 3 run-make tests that currently do)
 - rust-lang#137777 (Specialize `OsString::push` and `OsString as From` for UTF-8)
 - rust-lang#137832 (Fix crash in BufReader::peek())
 - rust-lang#137904 (Improve the generic MIR in the default `PartialOrd::le` and friends)
 - rust-lang#138115 (Suggest typo fix for static lifetime)
 - rust-lang#138125 (Simplify `printf` and shell format suggestions)
 - rust-lang#138129 (Stabilize const_char_classify, const_sockaddr_setters)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Mar 7, 2025
…=tgross35

Stabilize const_char_classify, const_sockaddr_setters

FCP for const_char_classify: rust-lang#132241
FCP for const_sockaddr_setters: rust-lang#131714

Fixes rust-lang#132241
Fixes rust-lang#131714

Cc ```@rust-lang/wg-const-eval```
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#136667 (Revert vita's c_char back to i8)
 - rust-lang#137107 (Override default `Write` methods for cursor-like types)
 - rust-lang#137777 (Specialize `OsString::push` and `OsString as From` for UTF-8)
 - rust-lang#137832 (Fix crash in BufReader::peek())
 - rust-lang#137904 (Improve the generic MIR in the default `PartialOrd::le` and friends)
 - rust-lang#138115 (Suggest typo fix for static lifetime)
 - rust-lang#138125 (Simplify `printf` and shell format suggestions)
 - rust-lang#138129 (Stabilize const_char_classify, const_sockaddr_setters)

r? `@ghost`
`@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 7, 2025
Rollup merge of rust-lang#138129 - RalfJung:stabilize-const-things, r=tgross35

Stabilize const_char_classify, const_sockaddr_setters

FCP for const_char_classify: rust-lang#132241
FCP for const_sockaddr_setters: rust-lang#131714

Fixes rust-lang#132241
Fixes rust-lang#131714

Cc ``@rust-lang/wg-const-eval``
@bors bors merged commit c33e9d6 into rust-lang:master Mar 7, 2025
6 checks passed
@rustbot rustbot added this to the 1.87.0 milestone Mar 7, 2025
@RalfJung RalfJung deleted the stabilize-const-things branch March 10, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for const_char_classify Tracking Issue for const_sockaddr_setters
6 participants