Update the standard library to Rust 2024 #138162

ehuss · 2025-03-07T14:09:33Z

This updates the standard library to Rust 2024. This includes the following notable changes:

Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.
Some tests show a change in MIR drop order. We do not believe this will be an observable change (see zulip discussion).

rustbot · 2025-03-07T14:09:38Z

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

ehuss · 2025-03-07T14:10:03Z

@bors try

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: aarch64-apple try-job: aarch64-gnu try-job: arm-android try-job: armhf-gnu try-job: dist-aarch64-apple try-job: dist-aarch64-linux try-job: dist-aarch64-msvc try-job: dist-android try-job: dist-apple-various try-job: dist-arm-linux try-job: dist-armhf-linux try-job: dist-armv7-linux try-job: dist-i586-gnu-i586-i686-musl try-job: dist-i686-linux try-job: dist-i686-mingw try-job: dist-i686-msvc try-job: dist-loongarch64-linux try-job: dist-loongarch64-musl try-job: dist-ohos try-job: dist-powerpc-linux

bors · 2025-03-07T14:11:15Z

⌛ Trying commit fab07c3 with merge a525bde...

bors · 2025-03-07T17:03:16Z

☀️ Try build successful - checks-actions
Build commit: a525bde (a525bde7d4aebdcc7c7ebf678404cbaf6245a0c2)

ehuss · 2025-03-07T23:51:55Z

@bors try

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64-linux try-job: dist-powerpc64le-linux try-job: dist-riscv64-linux try-job: dist-s390x-linux try-job: dist-various-1 try-job: dist-various-2 try-job: dist-x86_64-apple try-job: dist-x86_64-freebsd try-job: dist-x86_64-illumos try-job: dist-x86_64-linux try-job: dist-x86_64-mingw try-job: dist-x86_64-msvc try-job: dist-x86_64-musl try-job: dist-x86_64-netbsd try-job: i686-gnu-1 try-job: i686-gnu-2 try-job: i686-mingw-1 try-job: i686-mingw-2 try-job: i686-mingw-3 try-job: i686-msvc-1

bors · 2025-03-07T23:53:06Z

⌛ Trying commit fab07c3 with merge d5db994...

bors · 2025-03-08T02:11:04Z

💔 Test failed - checks-actions

bors · 2025-03-08T16:35:05Z

☔ The latest upstream changes (presumably #138208) made this pull request unmergeable. Please resolve the merge conflicts.

ehuss · 2025-03-08T19:00:09Z

@bors try

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: mingw-check try-job: test-various try-job: x86_64-apple-1 try-job: x86_64-apple-2 try-job: x86_64-fuchsia try-job: x86_64-gnu-distcheck try-job: x86_64-gnu-tools try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext2 try-job: x86_64-msvc-ext3 try-job: x86_64-rust-for-linux

bors · 2025-03-08T19:02:22Z

⌛ Trying commit 39d5d92 with merge fc2f6df...

bors · 2025-03-08T20:46:27Z

💔 Test failed - checks-actions

ehuss · 2025-03-08T21:22:49Z

@bors try

(weird random stack overflow in x86_64-mingw-1)

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081 (Draft while I do some try jobs, as this is a high-risk of breakage.) try-job: dist-powerpc64le-linux try-job: i686-gnu-1 try-job: i686-msvc-1 try-job: i686-msvc-2 try-job: x86_64-apple-1 try-job: x86_64-gnu-tools try-job: x86_64-mingw-1 try-job: x86_64-mingw-2 try-job: x86_64-msvc-1 try-job: x86_64-msvc-2 try-job: x86_64-msvc-ext1 try-job: x86_64-msvc-ext2 try-job: x86_64-msvc-ext3

bors · 2025-03-08T21:24:00Z

⌛ Trying commit 39d5d92 with merge 4758198...

jieyouxu · 2025-03-11T03:23:20Z

tests/ui/macros/std-2024-macros.rs

+// Tests a small handful of macros in the standard library how they handle the
+// new behavior introduced in 2024.


Suggestion: maybe slightly elaborate what said "new behavior" is? Like the PR description bit

Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing const {...} expressions now.

but added to the test comment?

jieyouxu · 2025-03-11T03:23:55Z

This is mostly library changes, so probably makes more sense to...

r? libs

When migrating the standard library to 2024, there will be some behavior changes that users will be able to observe. This test should cover that (I cannot think of any other observable differences).

cuviper · 2025-03-11T23:02:25Z

cc @rust-lang/libs-api for the macro :expr upgrade -- while I understand the need for an edition boundary, I think this perfectly safe for macros we control, and should be a strict upgrade. Feel free to take API control of the review if needed, otherwise it looks good to me!

@rustbot label +relnotes
@bors r+

bors · 2025-03-11T23:02:27Z

📌 Commit b130747 has been approved by cuviper

It is now in the queue for this repository.

Update the standard library to Rust 2024 This updates the standard library to Rust 2024. This includes the following notable changes: - Macros are updated to use new expression fragment specifiers. This PR includes a test to illustrate the changes, primarily allowing `const {...}` expressions now. - Some tests show a change in MIR drop order. We do not believe this will be an observable change ([see zulip discussion](https://rust-lang.zulipchat.com/#narrow/channel/268952-edition/topic/standard.20library.20migration/near/500972873)). Fixes rust-lang#133081

Rollup of 25 pull requests Successful merges: - rust-lang#134076 (Stabilize `std::io::ErrorKind::InvalidFilename`) - rust-lang#136842 (Add libstd support for Trusty targets) - rust-lang#137314 (change definitely unproductive cycles to error) - rust-lang#137504 (Move methods from Map to TyCtxt, part 4.) - rust-lang#137621 (Add std support to cygwin target) - rust-lang#137701 (Convert `ShardedHashMap` to use `hashbrown::HashTable`) - rust-lang#138109 (make precise capturing args in rustdoc Json typed) - rust-lang#138161 (Add PeekMut::refresh) - rust-lang#138162 (Update the standard library to Rust 2024) - rust-lang#138174 (Elaborate trait assumption in `receiver_is_dispatchable`) - rust-lang#138175 (Support rmeta inputs for --crate-type=bin --emit=obj) - rust-lang#138269 (uefi: fs: Implement FileType, FilePermissions and FileAttr) - rust-lang#138313 (Update books) - rust-lang#138318 (Rustdoc: remove a bunch of `@ts-expect-error` from main.js) - rust-lang#138331 (Use `RUSTC_LINT_FLAGS` more) - rust-lang#138333 (Rebuild llvm spuriously less frequently) - rust-lang#138343 (Enable `f16` tests for `powf`) - rust-lang#138345 (Some autodiff cleanups) - rust-lang#138346 (naked functions: on windows emit `.endef` without the symbol name) - rust-lang#138347 (Reduce `kw::Empty` usage, part 2) - rust-lang#138360 (Fix false-positive in `expr_or_init` and in the `invalid_from_utf8` lint) - rust-lang#138371 (Update compiletest's `has_asm_support` to match rustc) - rust-lang#138372 (Refactor `pick2_mut` & `pick3_mut` to use `get_disjoint_mut`) - rust-lang#138376 (Item-related cleanups) - rust-lang#138377 (Remove unnecessary lifetime from `PatInfo`.) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned BoxyUwU Mar 7, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2025

ehuss force-pushed the library-2024 branch 2 times, most recently from 2df2508 to 39d5d92 Compare March 8, 2025 18:55

rustbot added the O-windows Operating system: Windows label Mar 8, 2025

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2025

jieyouxu reviewed Mar 11, 2025

View reviewed changes

rustbot assigned cuviper and unassigned BoxyUwU Mar 11, 2025

ehuss added 13 commits March 11, 2025 09:46

Add a test for new 2024 standard library behavior

590b277

When migrating the standard library to 2024, there will be some behavior changes that users will be able to observe. This test should cover that (I cannot think of any other observable differences).

Migrate core to Rust 2024

0e071c2

Migrate alloc to Rust 2024

f505d4e

Migrate panic_abort to Rust 2024

b9454af

Migrate panic_unwind to Rust 2024

985f66b

Migrate unwind to Rust 2024

540ef90

Migrate std to Rust 2024

993359e

Migrate test to Rust 2024

f1a9513

Migrate proc_macro to Rust 2024

0b2489c

Migrate profiler_builtins to Rust 2024

80311c4

Migrated the rustc-std-workspace crates to Rust 2024

32c61f7

Migrate the sysroot crate to Rust 2024

ba06ce6

Migrate windows-targets to Rust 2024

b130747

ehuss force-pushed the library-2024 branch from 0b5c62e to b130747 Compare March 11, 2025 16:47

rustbot added the relnotes Marks issues that should be documented in the release notes of the next release. label Mar 11, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025

rustbot mentioned this pull request Mar 11, 2025

Tracking issue for release notes of #138162: Update the standard library to Rust 2024 #138375

Open

jieyouxu mentioned this pull request Mar 12, 2025

Rollup of 26 pull requests #138382

Closed

jieyouxu mentioned this pull request Mar 12, 2025

Rollup of 25 pull requests #138383

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the standard library to Rust 2024 #138162

Update the standard library to Rust 2024 #138162

ehuss commented Mar 7, 2025 •

edited

Loading

rustbot commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

bors commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

This comment has been minimized.

bors commented Mar 8, 2025

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

jieyouxu Mar 11, 2025 •

edited

Loading

ehuss Mar 11, 2025

jieyouxu commented Mar 11, 2025

cuviper commented Mar 11, 2025

bors commented Mar 11, 2025

		// Tests a small handful of macros in the standard library how they handle the
		// new behavior introduced in 2024.

Update the standard library to Rust 2024 #138162

Are you sure you want to change the base?

Update the standard library to Rust 2024 #138162

Conversation

ehuss commented Mar 7, 2025 • edited Loading

rustbot commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

bors commented Mar 7, 2025

ehuss commented Mar 7, 2025

bors commented Mar 7, 2025

This comment has been minimized.

bors commented Mar 8, 2025

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

bors commented Mar 8, 2025

ehuss commented Mar 8, 2025

bors commented Mar 8, 2025

This comment has been minimized.

jieyouxu Mar 11, 2025 • edited Loading

Choose a reason for hiding this comment

ehuss Mar 11, 2025

Choose a reason for hiding this comment

jieyouxu commented Mar 11, 2025

cuviper commented Mar 11, 2025

bors commented Mar 11, 2025

ehuss commented Mar 7, 2025 •

edited

Loading

jieyouxu Mar 11, 2025 •

edited

Loading