-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix some more unstable issue annotations #28038
Conversation
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
@@ -362,7 +362,7 @@ impl char { | |||
/// mostly similar to ID_Start but modified for closure under NFKx. | |||
#[unstable(feature = "unicode", | |||
reason = "mainly needed for compiler internals", | |||
issue = "0")] | |||
issue = "27784")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These actually aren't quite related to the character encoding methods because they're basically just compiler internals at this point, I don't think these are on the track to stabilization any time soon at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Seems strange that by writing #![feature(unicode)]
you then get access to this unrelated/internal thing as well as the possibly-en-route-to-stabilization unicode stuff. But anyway I'll remove this one and squash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this is a very old feature name and nowadays it'd be named something different, but alas!
Thanks! Just one nit but otherwise r=me |
3ae0d78
to
595fda0
Compare
Squashed. |
Ack! There are |
After submitting #28031, I ran a [script](https://gist.github.com/durka/a5243440697c780f669b) on the rest of src/ and found some anomalies. In this PR are the fixes that I thought were obvious (but I might be wrong!). The others I've submitted in issue #28037.
After submitting #28031, I ran a script on the rest of src/ and found some anomalies. In this PR are the fixes that I thought were obvious (but I might be wrong!). The others I've submitted in issue #28037.