resolve: Finish fixing #30159, a bug in import visibility #30866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r+, so long as crater says nice things @brson could you crater this please? |
bluss
added
the
S-waiting-on-crater
|
Starting a crater run |
|
Crater reports no regressions, but there are 544 unknown crates so it may not be super high fidelity (cc @brson) |
|
☔ The latest upstream changes (presumably #30843) made this pull request unmergeable. Please resolve the merge conflicts. |
… can make preceding imports public (fixes rust-lang#30159).
jseyfried
force-pushed
the
fix_shadowed_use_visibility
branch
from
22ac9df to
7a69ee0
Compare
|
rebased |
|
@bors: r+ |
|
📌 Commit 7a69ee0 has been approved by |
nrc
removed
the
S-waiting-on-crater
|
@jseyfried sorry, I lost track of this one |
|
No problem |
bors
added a commit
that referenced
this pull request
Feb 1, 2016
This reverts PR #30324, fixing bug #30159 in which a public a glob import makes public any preceding imports that share a name with an item in the module being glob imported from. For example, ```rust pub fn f() {} pub mod foo { fn f() {} } mod bar { use f; use f as g; pub use foo::*; // This makes the first import public but does not affect the second import. } ``` This is a [breaking-change].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts PR #30324, fixing bug #30159 in which a public a glob import makes public any preceding imports that share a name with an item in the module being glob imported from.
For example,
This is a [breaking-change].