-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stable features lint warning mentions version stabilized #33973
stable features lint warning mentions version stabilized #33973
Conversation
To accomplish this, we alter the checks in `rustc::middle::stability` to use the `StabilityLevel` defined in `syntax::attr` (which includes the version in which the feature was stabilized) rather than the local `StabilityLevel` in the same module, and make the `declared_stable_lang_features` field of `syntax::feature_gate::Features` hold a Vec of feature-name, span tuples (in analogy to the `declared_lib_features` field) rather than just spans. This is in the matter of issue rust-lang#33394.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I slightly edited your issue to read "Fixes #33394", so Github will close the relevant issue automatically. |
@bors r+ |
📌 Commit 06c9e0f has been approved by |
⌛ Testing commit 06c9e0f with merge 8bb86da... |
💔 Test failed - auto-linux-64-opt-rustbuild |
@bors: retry On Tue, May 31, 2016 at 3:50 PM, bors [email protected] wrote:
|
…notes_version_stabilized, r=brson stable features lint warning mentions version stabilized To accomplish this, we alter the checks in `rustc::middle::stability` to use the `StabilityLevel` defined in `syntax::attr` (which includes the version in which the feature was stabilized) rather than the local `StabilityLevel` in the same module, and make the `declared_stable_lang_features` field of `syntax::feature_gate::Features` hold a Vec of feature-name, span tuples (in analogy to the `declared_lib_features` field) rather than just spans. Fixes rust-lang#33394.  r? @brson (tagging Brian because he [wrote](rust-lang#21958) the lint)
To accomplish this, we alter the checks in
rustc::middle::stability
touse the
StabilityLevel
defined insyntax::attr
(which includes theversion in which the feature was stabilized) rather than the local
StabilityLevel
in the same module, and make thedeclared_stable_lang_features
field ofsyntax::feature_gate::Features
hold a Vec of feature-name, spantuples (in analogy to the
declared_lib_features
field) rather thanjust spans.
Fixes #33394.
r? @brson (tagging Brian because he wrote the lint)