-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E0496 to new format #36065
Update E0496 to new format #36065
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks! I wait for travis' confirmation before r+ it. Also, can you squash your commits please? If you don't know how to do, take a look here. |
Travis won't confirm, it's broken right now. |
3dbefef
to
ba7b163
Compare
squash done |
@acrrd: Travis and buildbot are broken for the moment. Once they're fixed, I'll r+. |
ba7b163
to
569eafd
Compare
There are some tests that fails, these are tests that check the warning and not the error; with my modifications the label of the warning also changed, is what we want? (I run make check-stage1, it ends with |
Sure: make check-stage1-cfail |
Thanks, that will help in avoiding to send PR with tests that do not pass. What about the tests? I can modify them to the new format also for the warning or I can modify the code the keep the old behavior for the warning. |
Just check what the command will return. It'll tell you what you need to update (and how). |
569eafd
to
63671c4
Compare
I have the fail also on master so I think my commit is ok |
Seems good. Thanks! @bors: r+ rollup |
📌 Commit 63671c4 has been approved by |
…Gomez Update E0496 to new format Fixes rust-lang#36000. Part of rust-lang#35233. r? @GuillaumeGomez
Fixes #36000.
Part of #35233.
r? @GuillaumeGomez