Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Owned to Static, Send to Owned #4166

Closed
wants to merge 3 commits into from

Conversation

brson
Copy link
Contributor

@brson brson commented Dec 12, 2012

r? @graydon
#3542

Although reception to this in the weekly meeting was pretty indifferent, I do think this is more consistent.

Note that Static will probably go away eventually.

@graydon
Copy link
Contributor

graydon commented Dec 12, 2012

Static is not the right word here. Lemme consult with a thesaurus for a moment...

(the "Owned" part is fine)

@graydon
Copy link
Contributor

graydon commented Dec 12, 2012

Stable, Durable or Enduring are ok by me, maybe other synonyms? static is currently used as a region, to refer to stuff in the read-only segment of memory. While it's true that this overlaps with the word const and the kind Const, fixing that is another bug. Adding another use for Static won't make the situation any prettier :(

@catamorphism points out that "stable" often means "GC won't move it", though I'm not sure that's something we'll be able to promise of @-containing values ever, and on others it's meaningless, so..

@brson
Copy link
Contributor Author

brson commented Dec 12, 2012

I like the sound of Durable over Enduring. I`ll rewrite the patch to use that unless something better comes up.

@nikomatsakis
Copy link
Contributor

I kind of prefer Static, in the sense that the meaning of this trait is (or ought to be) "no borrowed pointers except ones with static lifetime". Durable and Enduring don't give me much intuition. All that said I'd prefer if this were not a trait as @brson said.

@bstrie
Copy link
Contributor

bstrie commented Dec 13, 2012

Maybe it's time to bite the bullet and just call it NotBorrowed? Or maybe it's time to consult non-English languages for appropriate words and put those Unicode identifiers to use.

@brson
Copy link
Contributor Author

brson commented Dec 13, 2012

@nikomatsakis has agreed that Durable is fine, considering that we intend to remove the kind anyway. Yay, consensus!

@brson brson closed this Dec 14, 2012
bors pushed a commit to rust-lang-ci/rust that referenced this pull request May 15, 2021
…#4166)

Previously the indetation of a line was compared with the configured
number of spaces per tab, which could cause lines that were formatted
with hard tabs not to be recognized as indented ("\t".len() < "    ".len()).

Closes rust-lang#4152
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants