Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser: Do not override syntactic context for dummy spans #50152

Merged
merged 1 commit into from
Apr 22, 2018
Merged

parser: Do not override syntactic context for dummy spans #50152

merged 1 commit into from
Apr 22, 2018

Conversation

petrochenkov
Copy link
Contributor

Fixes #50061

e2afefd seemingly did everything right, but uncovered a preexisting bug.

@rust-highfive
Copy link
Collaborator

r? @michaelwoerister

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2018
@petrochenkov
Copy link
Contributor Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Apr 22, 2018

📌 Commit 6a4e0b3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2018
@bors
Copy link
Contributor

bors commented Apr 22, 2018

⌛ Testing commit 6a4e0b3 with merge ff48277...

bors added a commit that referenced this pull request Apr 22, 2018
@bors
Auto merge of #50152 - petrochenkov:nooverhyg, r=alexcrichton
ff48277 
parser: Do not override syntactic context for dummy spans

Fixes #50061

e2afefd seemingly did everything right, but uncovered a preexisting bug.
@bors
Copy link
Contributor

bors commented Apr 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing ff48277 to master...

@bors bors merged commit 6a4e0b3 into rust-lang:master Apr 22, 2018
@alexcrichton alexcrichton mentioned this pull request Apr 23, 2018
Closed
@golddranks golddranks mentioned this pull request May 1, 2018
Closed
@petrochenkov petrochenkov deleted the nooverhyg branch June 5, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrochenkov @rust-highfive @alexcrichton @bors @michaelwoerister