submodules: update clippy, rls and cargo, fix toolstate #54916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ |
|
📌 Commit 756eb263d3d5b75ae6286c9b8d18d7d09eaf67d7 has been approved by |
bors
added
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #54969) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
matthiaskrgr
force-pushed
the
submodules_update
branch
from
756eb26 to
0d640de
Compare
|
rebased |
matthiaskrgr
force-pushed
the
submodules_update
branch
from
0d640de to
87f5fc4
Compare
matthiaskrgr
changed the title
|
@bors r+ p=1 |
|
📌 Commit 87f5fc4 has been approved by |
bors
added
S-waiting-on-bors
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Oct 11, 2018
…li-obk submodules: update clippy, rls and cargo, fix toolstate rustfmt update failed because of different rustc-ap-syntax versions. fix clippy toolstate failure Fixes rust-lang#54697
bors
added a commit
that referenced
this pull request
Oct 11, 2018
submodules: update clippy, rls and cargo, fix toolstate rustfmt update failed because of different rustc-ap-syntax versions. fix clippy toolstate failure Fixes #54697
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Does that mean the binary was not found?Tthat's strange because I didn't see any clippy build failures in the log. |
|
cc @rust-lang/infra |
|
This doesn't really look like a out-of-the-ordinary issue wrt building things, and it seems like it's probably related to the clippy submodule update. I'd recommend running the same steps locally and seeing if it fails, and perhaps using |
|
I don't have a windows env available and I but run the tests of all the changed submodules locally on linux and didn't see any regressions. Hmm... |
kennytm
added
S-waiting-on-author
|
The bug here looks to be in packaging probably, so you'll need to be executing |
|
That worked, thanks. |
Changes: Remove now-useless `allow(unknown_lints)` Stabilize tool lints Use `impl Iterator` in arg position in clippy_dev Fix fn_to_numeric_cast_with_truncation suppression Limit commutative assign op lint to primitive types Clarify code Fix rust-lang#2937 Fix cast_possible_wrap and cast_sign_loss warnings Fix cast_possible_truncation warnings Fixes rust-lang#2925 cmp_owned false positive if_let_redundant_pattern_matching: use Span.to() instead of Span.with_hi() to fix crash. Improve diagnostics in case of lifetime elision (closes rust-lang#3284) Fix items_after_statements for `const`s Fix items_after_statements for sub-functions Fix items_after_statements for `use` statements Don't suggest cloned() for map Box deref Fix excessive_precision false positive Fix FP in `fn_to_numeric_cast_with_truncation` new_without_default should not warn about unsafe new fix command to manually test an example Add license to README Adding more detail to filter_map lint documentation. additional people Add license header to other files Add license header to Rust files Relicense clippy Document relicensing process Fix util/export.py to include lints from methods
Changes: Apply Clippy lints Respect build_dir when creating external build plans Fix Windows tests Implement external build plan Detect manifest diagnostic position for toml::de::Error Fix std::sync hover doc expectation Apply CI specific long timeout Propagate cargo errors as manifest diagnostics Add test for use statement function completions Refactor cmd test `within_timeout` Avoid stdout-writer/rls process exit race Improve cmd test "no shutdown response" error message Add RUST_BACKTRACE=1 to ci env Improve cmd test timeout reliability Fix use statement function suggestions Revert "Revert "Remove "edition" Cargo feature (it's stable now)"" Add build_wait() tests Automatically tune wait_to_build Rework cmd tests Fixes rust-lang#54697
Changes: Switch to use crates-io as the registry name and don't include publish when registry is not specified fix redundant pkgid generation validate some basic properties of a valid resolve Detail dep name in invalid version error Fix dashes in rename dependencies. Bump flate2 to 1.0.3 Add default in config document Add support for providing a default registry Add support for registry to new and init use impl Iterator instead of custom types in `source` let jetbrains reorder some impls to match the definition use impl Iterator instead of custom types in resolver and graph remove Graph::sort as it is unused fmt Bump libgit2-sys to 0.7.9 Switch to use registry Allow registry option for cargo install. Second attempt at fixing msys terminal width. Try to improve "version not found" error Fix typo
|
I probably need to update the dist install step to point to the new license files. |
matthiaskrgr
force-pushed
the
submodules_update
branch
from
87f5fc4 to
9c651b3
Compare
|
Should be good to go now. |
|
@bors r+ p=1 |
|
📌 Commit 9c651b3 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 13, 2018
submodules: update clippy, rls and cargo, fix toolstate rustfmt update failed because of different rustc-ap-syntax versions. fix clippy toolstate failure Fixes #54697
|
☀️ Test successful - status-appveyor, status-travis |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 13, 2018
Tested on commit rust-lang/rust@4699283. Direct link to PR: <rust-lang/rust#54916> 🎉 clippy-driver on windows: test-fail → test-pass. 🎉 clippy-driver on linux: test-fail → test-pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustfmt update failed because of different rustc-ap-syntax versions.
fix clippy toolstate failure
Fixes #54697