Fix span for closure return type when annotated. #58180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
estebank
reviewed
Feb 5, 2019
src/librustc_mir/borrow_check/nll/region_infer/error_reporting/region_name.rs
Show resolved
Hide resolved
estebank
reviewed
Feb 5, 2019
This commit adjusts the span used to label closure return types so that
if the user specifies the return type, i.e. `|_| -> X {}` instead of
`|_| {}`, we correctly highlight all of it and not just the last
character.
davidtwco
force-pushed
the
issue-58053
branch
from
9ae3725 to
b377d0b
Compare
|
@bors r+ |
|
📌 Commit b377d0b has been approved by |
bors
added
S-waiting-on-bors
|
@bors treeclosed- |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58053.
This PR adjusts the span used to label closure return types so that
if the user specifies the return type, i.e.
|_| -> X {}instead of|_| {}, we correctly highlight all of it and not just the lastcharacter.
r? @pnkfelix