-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: parse swapped pub and async #59395
Conversation
It's weird that your For now, I think that you're only changing the code for trait items, like
but I think that will still not trigger because of it gets caught at |
yes, the expected error isn't appeared. If the process doesn't reach, we should touch other places, I think. What should I do? |
@estebank Uh, Should I close this PR once, or work on? |
☔ The latest upstream changes (presumably #59810) made this pull request unmergeable. Please resolve the merge conflicts. |
@JohnTitor sorry for not being more responsive, I've been away for a couple of weeks.
I'll take a look at this sometimes this week to find where the right place to touch is, but you're certainly in the right "neighborhood". |
@estebank Can you take a look at this PR again? It looks like @JohnTitor still needs some help. |
I'm sorry but I can't have time to investigate at this time. Feel free to close this PR if we need to investigate more. |
No worries! Let us know if you decide to re-investigate so we can reopen this pull request or you can also just open a new one. |
This is a draft
cc: #52790
r? @estebank