Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] NLL crater run 1: switch default borrowck mode from migrate to full NLLs #60911

Closed
wants to merge 1 commit into from

Conversation

lqd
Copy link
Member

@lqd lqd commented May 17, 2019

This switches the default borrowck mode from migrate to mir for one of the crater runs needed for #60680.

For the previous runs, we also specified crater to cap-lints=warn, we might want this again this time ?

r? @ghost

cc @pnkfelix, @Centril

@matthewjasper
Copy link
Contributor

@bors try

@bors
Copy link
Contributor

bors commented May 17, 2019

⌛ Trying commit b5a0eff with merge 3b83c7bdae78b891a5c94820bc79a60a5ade42b8...

@bors
Copy link
Contributor

bors commented May 17, 2019

☀️ Try build successful - checks-travis
Build commit: 3b83c7bdae78b891a5c94820bc79a60a5ade42b8

@matthewjasper
Copy link
Contributor

@craterbot run start=master#68fd80fa1efb74863bda050b21edcd44125ee85b end=try#3b83c7bdae78b891a5c94820bc79a60a5ade42b8 mode=check-only

@craterbot
Copy link
Collaborator

👌 Experiment pr-60911 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added the S-waiting-on-crater Status: Waiting on a crater run to be completed. label May 17, 2019
@craterbot
Copy link
Collaborator

🚧 Experiment pr-60911 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚨 Experiment pr-60911 has encountered an error: some threads returned an error
🛠️ If the error is fixed use the retry command.

🆘 Can someone from the infra team check in on this? @rust-lang/infra
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@pietroalbini
Copy link
Member

@craterbot retry

@craterbot
Copy link
Collaborator

🛠️ Experiment pr-60911 queued again.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-60911 is now running on agent aws-2.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-60911 is completed!
📊 1998 regressed and 0 fixed (60951 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels May 22, 2019
@lqd
Copy link
Member Author

lqd commented May 22, 2019

Here as well: 99 crates causing 1892 failures downstream, 140 crates themselves failing to build. 220 crates in total (all the 131 in the other run + these 89 new ones)

@lqd
Copy link
Member Author

lqd commented May 23, 2019

The lang team should have the data they need for this run, so closing the PR.

@lqd lqd closed this May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants