-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add partition_point #73577
Merged
Merged
Add partition_point #73577
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4c8ce48
Add partition_point
VillSnow c9b4915
fix: doc test
VillSnow 27b06f1
update: doc comment
VillSnow 8cc6998
add: tests
VillSnow 52f9762
Add comment on use of unsafe
VillSnow 9335787
Update src/libcore/slice/mod.rs
VillSnow 83d5998
Merge branch 'master' of https://github.com/VillSnow/rust
VillSnow d720a19
Update doc comment
VillSnow 60f2ba2
Update tracking issue number
VillSnow 6f8ad3b
Update src/libcore/slice/mod.rs
VillSnow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2663,6 +2663,46 @@ impl<T> [T] { | |
{ | ||
self.iter().is_sorted_by_key(f) | ||
} | ||
|
||
/// Returns index of partition point according to the given predicate, | ||
/// such that all those that return true precede the index and | ||
/// such that all those that return false succeed the index. | ||
/// | ||
/// The slice must be partitioned | ||
/// so that all elements where the predicate returns true | ||
/// precede the elements where the predicate returns false. | ||
/// | ||
/// # Examples | ||
/// | ||
/// ``` | ||
/// #![feature(partition_point)] | ||
/// | ||
/// let v = [1, 2, 3, 3, 5, 6, 7]; | ||
/// let i = v.partition_point(|&x| x < 5); | ||
/// | ||
/// assert_eq!(i, 4); | ||
/// assert!(v[..i].iter().all(|&x| x < 5)); | ||
/// assert!(v[i..].iter().all(|&x| !(x < 5))); | ||
/// ``` | ||
#[unstable(feature = "partition_point", reason = "new API", issue = "99999")] | ||
pub fn partition_point<P>(&self, mut pred: P) -> usize | ||
where | ||
P: FnMut(&T) -> bool, | ||
{ | ||
let mut left = 0; | ||
let mut right = self.len(); | ||
|
||
while left != right { | ||
let mid = left + (right - left) / 2; | ||
let value = unsafe { self.get_unchecked(mid) }; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add a comment about why this |
||
if pred(value) { | ||
left = mid + 1; | ||
} else { | ||
right = mid; | ||
} | ||
} | ||
return left; | ||
VillSnow marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
} | ||
|
||
#[lang = "slice_u8"] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this text could be improved. In particular, I had to check the example to understand whether the returned index is the last index of the first half or the first index of the second half. One suggestion: