Rollup of 5 pull requests #78976

GuillaumeGomez · 2020-11-12T10:31:55Z

Successful merges:

extend const generics test suite #78916 (extend const generics test suite)
Improve the page title switch handling between search and doc #78921 (Improve the page title switch handling between search and doc)
Don't print thread ids and names in tracing logs #78933 (Don't print thread ids and names in tracing logs)
Test default values for const parameters. #78960 (Test default values for const parameters.)
Update books #78971 (Update books)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Before: ``` 2:rustc INFO rustc_interface::passes Pre-codegen 2:rustcTy interner total ty lt ct all 2:rustc Adt : 1078 81.3%, 0.0% 0.0% 0.0% 0.0% 2:rustc Array : 1 0.1%, 0.0% 0.0% 0.0% 0.0% 2:rustc Slice : 1 0.1%, 0.0% 0.0% 0.0% 0.0% 2:rustc RawPtr : 2 0.2%, 0.0% 0.0% 0.0% 0.0% 2:rustc Ref : 4 0.3%, 0.1% 0.1% 0.0% 0.0% 2:rustc FnDef : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc FnPtr : 76 5.7%, 0.0% 0.0% 0.0% 0.0% 2:rustc Placeholder : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Generator : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc GeneratorWitness : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Dynamic : 3 0.2%, 0.0% 0.0% 0.0% 0.0% 2:rustc Closure : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Tuple : 13 1.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Bound : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Param : 146 11.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Infer : 2 0.2%, 0.1% 0.0% 0.0% 0.0% 2:rustc Projection : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Opaque : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Foreign : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc total 1326 0.2% 0.1% 0.0% 0.0% 2:rustcInternalSubsts interner: rust-lang#437 2:rustcRegion interner: rust-lang#355 2:rustcStability interner: #1 2:rustcConst Stability interner: #0 2:rustcAllocation interner: #0 2:rustcLayout interner: #0 ``` After: ``` INFO rustc_interface::passes Post-codegen Ty interner total ty lt ct all Adt : 1078 81.3%, 0.0% 0.0% 0.0% 0.0% Array : 1 0.1%, 0.0% 0.0% 0.0% 0.0% Slice : 1 0.1%, 0.0% 0.0% 0.0% 0.0% RawPtr : 2 0.2%, 0.0% 0.0% 0.0% 0.0% Ref : 4 0.3%, 0.1% 0.1% 0.0% 0.0% FnDef : 0 0.0%, 0.0% 0.0% 0.0% 0.0% FnPtr : 76 5.7%, 0.0% 0.0% 0.0% 0.0% Placeholder : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Generator : 0 0.0%, 0.0% 0.0% 0.0% 0.0% GeneratorWitness : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Dynamic : 3 0.2%, 0.0% 0.0% 0.0% 0.0% Closure : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Tuple : 13 1.0%, 0.0% 0.0% 0.0% 0.0% Bound : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Param : 146 11.0%, 0.0% 0.0% 0.0% 0.0% Infer : 2 0.2%, 0.1% 0.0% 0.0% 0.0% Projection : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Opaque : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Foreign : 0 0.0%, 0.0% 0.0% 0.0% 0.0% total 1326 0.2% 0.1% 0.0% 0.0% InternalSubsts interner: rust-lang#437 Region interner: rust-lang#355 Stability interner: #1 Const Stability interner: #0 Allocation interner: #0 Layout interner: #0 ```

extend const generics test suite should implement most of rust-lang#78433, especially all parts of [the hackmd](https://hackmd.io/WnFmN4MjRCqAjGmYfYcu2A?view) which I did not explicitly mention in that issue. r? ``@varkor``

… r=jyn514 Improve the page title switch handling between search and doc The current behavior often "forgets" to update the page title when discarding/putting back the search results. This isn't optimal which is why I wrote this fix. r? ``@jyn514``

Don't print thread ids and names in `tracing` logs Before: ``` 2:rustc INFO rustc_interface::passes Pre-codegen 2:rustcTy interner total ty lt ct all 2:rustc Adt : 1078 81.3%, 0.0% 0.0% 0.0% 0.0% 2:rustc Array : 1 0.1%, 0.0% 0.0% 0.0% 0.0% 2:rustc Slice : 1 0.1%, 0.0% 0.0% 0.0% 0.0% 2:rustc RawPtr : 2 0.2%, 0.0% 0.0% 0.0% 0.0% 2:rustc Ref : 4 0.3%, 0.1% 0.1% 0.0% 0.0% 2:rustc FnDef : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc FnPtr : 76 5.7%, 0.0% 0.0% 0.0% 0.0% 2:rustc Placeholder : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Generator : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc GeneratorWitness : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Dynamic : 3 0.2%, 0.0% 0.0% 0.0% 0.0% 2:rustc Closure : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Tuple : 13 1.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Bound : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Param : 146 11.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Infer : 2 0.2%, 0.1% 0.0% 0.0% 0.0% 2:rustc Projection : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Opaque : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc Foreign : 0 0.0%, 0.0% 0.0% 0.0% 0.0% 2:rustc total 1326 0.2% 0.1% 0.0% 0.0% 2:rustcInternalSubsts interner: rust-lang#437 2:rustcRegion interner: rust-lang#355 2:rustcStability interner: #1 2:rustcConst Stability interner: #0 2:rustcAllocation interner: #0 2:rustcLayout interner: #0 ``` After: ``` INFO rustc_interface::passes Post-codegen Ty interner total ty lt ct all Adt : 1078 81.3%, 0.0% 0.0% 0.0% 0.0% Array : 1 0.1%, 0.0% 0.0% 0.0% 0.0% Slice : 1 0.1%, 0.0% 0.0% 0.0% 0.0% RawPtr : 2 0.2%, 0.0% 0.0% 0.0% 0.0% Ref : 4 0.3%, 0.1% 0.1% 0.0% 0.0% FnDef : 0 0.0%, 0.0% 0.0% 0.0% 0.0% FnPtr : 76 5.7%, 0.0% 0.0% 0.0% 0.0% Placeholder : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Generator : 0 0.0%, 0.0% 0.0% 0.0% 0.0% GeneratorWitness : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Dynamic : 3 0.2%, 0.0% 0.0% 0.0% 0.0% Closure : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Tuple : 13 1.0%, 0.0% 0.0% 0.0% 0.0% Bound : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Param : 146 11.0%, 0.0% 0.0% 0.0% 0.0% Infer : 2 0.2%, 0.1% 0.0% 0.0% 0.0% Projection : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Opaque : 0 0.0%, 0.0% 0.0% 0.0% 0.0% Foreign : 0 0.0%, 0.0% 0.0% 0.0% 0.0% total 1326 0.2% 0.1% 0.0% 0.0% InternalSubsts interner: rust-lang#437 Region interner: rust-lang#355 Stability interner: #1 Const Stability interner: #0 Allocation interner: #0 Layout interner: #0 ``` Closes rust-lang#78931 r? ``@oli-obk``

…ror, r=lcnr Test default values for const parameters. The last topic on rust-lang#78433 I originally intended to place these tests in a single file, however, due to them being parser errors that are fatal, they must be in separate files to be detected. Thanks, ``@lcnr`` for mentoring me on this PR. r? ``@lcnr``

Update books ## nomicon 8 commits in 69333eddb1de92fd17e272ce4677cc983d3bd71d..23c49f1d5ce4720bc5b7e3a920f47eccc8da6b63 2020-10-17 15:44:12 -0700 to 2020-11-05 13:30:53 +0900 - (rust-lang/nomicon#238) - Some tweaks (rust-lang/nomicon#244) - (rust-lang/nomicon#245) - Update atomics.md (rust-lang/nomicon#224) - Update send-and-sync.md (rust-lang/nomicon#187) - fix a typo (rust-lang/nomicon#231) - Improve formatting of "Transmutes" chapter (rust-lang/nomicon#242) - Merge pull request rust-lang/nomicon#241 from simon-lammes/patch-1 ## reference 4 commits in 10c16caebe475d0d11bec0531b95d7697856c13c..a7de763c213292f5b44bf10acb87ffa38724814d 2020-10-25 20:51:26 -0700 to 2020-11-11 19:13:21 -0800 - Referencify tuples (rust-lang/reference#899) - Mention Box's partial field moves (rust-lang/reference#837) - Enable triagebot (rust-lang/reference#862) - Update deprecated GitHub Actions commands. (rust-lang/reference#896) ## rust-by-example 1 commits in 99eafee0cb14e6ec641bf02a69d7b30f6058349a..1886fda6981b723e4de637074455558f8bc1e83c 2020-10-21 14:21:55 -0300 to 2020-10-28 13:46:54 -0500 - Remove incorrect "lambda" terminology ## edition-guide 1 commits in 7bc9b7a5e800f79df62947cb7d566fd2fbaf19fe..b91a9a881ee007c12e74e844460ec407cf07a50f 2020-10-23 18:31:23 -0500 to 2020-11-02 11:02:03 -0600 - Clarify slice patterns example (rust-lang/edition-guide#223)

GuillaumeGomez · 2020-11-12T10:32:06Z

@bors: r+ p=5

bors · 2020-11-12T10:32:07Z

📌 Commit cac8ac6 has been approved by GuillaumeGomez

bors · 2020-11-12T13:10:13Z

⌛ Testing commit cac8ac6 with merge 7f5a42b...

bors · 2020-11-12T15:33:59Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 7f5a42b to master...

lcnr and others added 22 commits November 10, 2020 09:51

const param macro test

d76cdb0

add generic param mismatch test

359031e

add macro_rules test regarding braces

dd78188

add associated type bounds test

a8310e2

exhaustively enumerate all values of a const param

19a3fe6

try referencing outer params

a30b28e

const param in async

de1ebbb

add test for where clauses mentioning const params

4b5cd04

add cross crate test

f4790ec

Improve the page title switch handling between search and doc

46c921d

Enable thread names in debug logging only for parallel_compiler

6e9ed8b

add rustdoc test

7d9f815

add error-in-impl-trait const generics test

a9eacf3

Add test default_function_param

ad7f330

default_trait_param

1d3f9d0

Update books

a8bc954

rustbot added the rollup A PR which is a rollup label Nov 12, 2020

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 12, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 12, 2020

bors merged commit 7f5a42b into rust-lang:master Nov 12, 2020

rustbot added this to the 1.49.0 milestone Nov 12, 2020

GuillaumeGomez deleted the rollup-endkih3 branch November 12, 2020 15:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 5 pull requests #78976

Rollup of 5 pull requests #78976

GuillaumeGomez commented Nov 12, 2020

GuillaumeGomez commented Nov 12, 2020

bors commented Nov 12, 2020

bors commented Nov 12, 2020

bors commented Nov 12, 2020

Rollup of 5 pull requests #78976

Rollup of 5 pull requests #78976

Conversation

GuillaumeGomez commented Nov 12, 2020

GuillaumeGomez commented Nov 12, 2020

bors commented Nov 12, 2020

bors commented Nov 12, 2020

bors commented Nov 12, 2020