Add more span suggestions

[Milo123459]

Hey, first PR. This just adds some new span_suggestion's to some errors.

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nagisa (or someone else) soon.

Please see the contribution instructions for more information.

[Milo123459]

I was going to attempt to add something to the async closures are unstable error, but I'm not sure how to add another help section. It looks like a macro invocation (gate_all!) is being used

[nagisa]

r? @estebank

From my perspective a more descriptive PR title and description would be helfpul. Something like "Implement machine applicable suggestions for static closures and loop control flow constructs" for the title and describe why these are okay as machine-applicable hints in these situations.

[estebank]

Thanks for doing this! I left some inline comments asking for changes.

[estebank]

Also, you'll need to run ./x.py fmt before submitting, otherwise CI will complain and won't let us merge.

[estebank]

You have a missing import after applying my suggested changes:

help: consider importing one of these items
    |
1   | use crate::path::BytePos;

[Milo123459]

Kinda confused as I added the use in and it still fails?

[bugaevc]

In the static closure case, perhaps a better suggestion would be to use move? Assuming the person was trying to make the closure be 'static.

error[E0697]: cannot use `static` keyword on closures
  --> $DIR/E0697.rs:2:5
   |
LL |     static || {};
   |     ^^^^^^^^^ help: to make the closure capture its environment by
   |               value and have a `'static` lifetime, use the `move`
   |               keyword: `move || {}`
   = note: for more on capturing environment with closures, read https://doc.rust-lang.org/book/ch13-01-closures.html#capturing-the-environment-with-closures

[Milo123459]

Hey - sorry I was gone, got caught up with something else. Let me fix this

[jyn514]

@Milo123459 the error is in compiler/rustc_ast_lowering/src/expr.rs, but you only added the import to compiler/rustc_typeck/src/check/pat.rs. I recommend running x.py check locally, it will give much faster feedback and also the errors will be easier to read.

[nagisa]

Please undo the changes to Cargo.lock. Updates to the dependency versions should only occur as a separate and well informed decisions.

[Milo123459]

Hm.. running git rebase master has done that..

[Milo123459]

Please undo the changes to Cargo.lock. Updates to the dependency versions should only occur as a separate and well informed decisions.

Yes, I have tried that with git rebase: can't figure out what's going on here, I'm questioning why this even changed as well

[Milo123459]

I think something locally has broken my branch 🤔

[rust-log-analyzer]

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

    Checking rustc_query_system v0.0.0 (/checkout/compiler/rustc_query_system)
    Checking rustc_parse v0.0.0 (/checkout/compiler/rustc_parse)
    Checking rustc_middle v0.0.0 (/checkout/compiler/rustc_middle)
    Checking rustc_ast_lowering v0.0.0 (/checkout/compiler/rustc_ast_lowering)
error[E0432]: unresolved import `rustc_span::hygiene::ForLoopLoc`
   |
   |
15 | use rustc_span::{hygiene::ForLoopLoc, BytePos, DUMMY_SP};
   |                  ^^^^^^^^^^^^^^^^^^^ no `ForLoopLoc` in `hygiene`
For more information about this error, try `rustc --explain E0432`.
error: could not compile `rustc_ast_lowering` due to previous error
warning: build failed, waiting for other jobs to finish...
error: build failed

[bors]

☔ The latest upstream changes (presumably #92560) made this pull request unmergeable. Please resolve the merge conflicts.