Stabilize binop_separator. #4144
Conversation
Servo has used this since forever, and it'd be useful to be able to use rustfmt stable there so that we can use the same rustfmt version in both Firefox and Servo. Feel free to close this if there's any reason it shouldn't be done. Closes rust-lang#3368
|
I think we'll need to resolve #3208 before stabilizing this.
Technically you already can use cargo +stable fmt -- --config binop_separator=back Note there's a good chance that may change when we release rustfmt 2.0 though. |
Hmm? I'm not sure I agree with the expectation, fwiw. Current output looks fine to me but.. :) |
|
We can't stabilize a config option that has open issues (https://github.com/rust-lang/rustfmt/blob/master/Processes.md#conditions). Regardless of how #3208 is resolved, (even if that does indeed turn out to be a closed/wont-fix) we would need to get that one closed before merging this. |
|
Sure, that's fine. I had searched for open issues fwiw, that one just didn't show up because the name of the option wasn't mentioned :) Well then this is fine to wait or what not. Though given it's been open since 2018 and without any progress, or other complaints, maybe it's fine to wontfix it. Anyhow not my call, so let me know if you want me to close this or leave this open, etc. Thanks :) |
No worries! I feel I'd seen this one not too long ago so it was in the back of my brain already.
In fairness there's probably quite a few unstable config options that fall into that bucket, but that's mostly because there hasn't been enough bandwidth to dig into the unstable opts. We've been mostly focused on getting rustfmt 2.0 out (and dealing with upstream rustc changes), and were generally planning to revisit the unstable opts after the 2.0 release.
I'm planning to leave it open for now. Based on the below threads from the style guide, it seems the indent shown in #3208 is aligned with the style guide so we may be able to close that and merge this in time for the 2.0 release. Though if #3208 ends up needing work to resolve then will probably close this |
|
@emilio @calebcartwright My apologies for the delay in confirming #3208. The issue doesn't seem to be a problem; rustfmt adds an extra indentation if binary expressions span to multiple lines. I will go ahead and close the issue as working as expected. |
|
So can we stabilize this? |
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen etc also use it by default, and this would allow them to move to stable rust.
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen etc also use it by default, and this would allow them to move to stable rust. Fixes rust-lang#3368 again.
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen etc also use it by default, and this would allow them to move to stable rust. Fixes rust-lang#3368 again.
See reasoning in rust-lang#4144, which still applies. Other projects like bindgen etc also use it by default, and this would allow them to move to stable rust. Fixes rust-lang#3368 again.
Servo has used this since forever, and it'd be useful to be able to use
rustfmt stable there so that we can use the same rustfmt version in
both Firefox and Servo.
Feel free to close this if there's any reason it shouldn't be done.
Closes #3368