Union discussions #369
Closed
Union discussions #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alercah
force-pushed
the
union-discussion
branch
from
49b1470 to
06ba02c
Compare
RalfJung
reviewed
Oct 31, 2022
| * Is `#[repr(Rust)]` the bag-o-bytes union repr, or do we want to propose a new repr? | ||
| * *Discussion:* [#73: Validity of unions][#73] | ||
| * The following questions are all implicitly answered if `#[repr(Rust)]` is the bag-o-bytes repr, but remain open if not: | ||
| * Do `#[repr(Rust)]` unions guarantee all fields at offset 0? |
There was a problem hiding this comment.
Even bag-of-bytes unions could have fields at non-0 offsets. Not sure if there is any reason to do that, but this makes it sound like there is a necessary logical implication from bag-of-bytes to 0-offset, which I don't think is the case.
RalfJung
reviewed
Oct 31, 2022
| * *Discussion*: [#353: Offsets of union fields][#353] | ||
| * Do `#[repr(Rust)]` unions have internal padding? | ||
| * *Discussion*: [#354: Do #[repr(Rust)] unions have internal padding?][#354] | ||
| * Do `#[repr(transparent)]` unions ever have niches? |
There was a problem hiding this comment.
This one, OTOH, is answered by bag-of-bytes -- right?
|
Closing due to inactivity. Note that the UCG book isn't really maintained these days -- probably the proper thing would be to write up a markdown document, schedule a t-opsem meeting, use that to update the document, and then FCP the result. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumes #365 and #368 are merged.